Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 206333007: Fix skia_library.gypi for Arm64. (Closed)

Created:
6 years, 9 months ago by rmcilroy
Modified:
6 years, 9 months ago
Reviewers:
Nico, djsollen, djsollen1
CC:
chromium-reviews, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@a64_atomic_protobuf
Visibility:
Public.

Description

Fix skia_library.gypi for Arm64. BUG=354405 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M skia/skia_library.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
rmcilroy
PTAL.
6 years, 9 months ago (2014-03-20 19:22:15 UTC) #1
Nico
lgtm
6 years, 9 months ago (2014-03-20 19:22:43 UTC) #2
djsollen
lgtm
6 years, 9 months ago (2014-03-20 19:24:28 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-20 19:25:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/206333007/1
6 years, 9 months ago (2014-03-20 19:26:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 19:32:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-20 19:32:20 UTC) #7
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-20 22:13:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/206333007/1
6 years, 9 months ago (2014-03-20 22:15:55 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 22:23:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-20 22:23:26 UTC) #11
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-20 22:25:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/206333007/1
6 years, 9 months ago (2014-03-20 22:27:03 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 22:34:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-20 22:34:12 UTC) #15
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-20 22:55:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/206333007/1
6 years, 9 months ago (2014-03-20 22:59:20 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 11:30:41 UTC) #18
Message was sent while issue was closed. 
Change committed as 258525

Powered by Google App Engine
This is Rietveld 408576698