Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 206333003: Rename a64 target arch to arm64 in blink_heap.gypi (Closed)

Created:
6 years, 9 months ago by rmcilroy
Modified:
6 years, 9 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename a64 target arch to arm64 in blink_heap.gypi BUG=354405 R=ager@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169734

Patch Set 1 #

Patch Set 2 : Rename file to arm64 too #

Patch Set 3 : Add missing file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -63 lines) Patch
D Source/heap/asm/SaveRegisters_a64.S View 1 1 chunk +0 lines, -62 lines 0 comments Download
A + Source/heap/asm/SaveRegisters_arm64.S View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/heap/blink_heap.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
jochen (gone - plz use gerrit)
Please rename the file (and if there are comments) as well Also, can you file ...
6 years, 9 months ago (2014-03-20 12:02:54 UTC) #1
Mads Ager (chromium)
LGTM with the file renamed as Jochen suggests.
6 years, 9 months ago (2014-03-20 12:07:35 UTC) #2
haraken
LGTM
6 years, 9 months ago (2014-03-20 12:07:57 UTC) #3
rmcilroy
On 2014/03/20 12:07:57, haraken wrote: > LGTM Thanks all. Renamed file and linked to the ...
6 years, 9 months ago (2014-03-20 19:04:33 UTC) #4
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-20 19:05:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/206333003/30001
6 years, 9 months ago (2014-03-20 19:05:58 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 19:09:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 19:09:11 UTC) #8
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-20 19:32:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/206333003/30001
6 years, 9 months ago (2014-03-20 19:32:53 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 19:36:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 19:36:34 UTC) #12
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-20 22:17:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/206333003/30001
6 years, 9 months ago (2014-03-20 22:17:46 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 22:29:14 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-20 22:29:15 UTC) #16
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 9 months ago (2014-03-21 09:41:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/206333003/30001
6 years, 9 months ago (2014-03-21 09:41:57 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 09:55:01 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-21 09:55:01 UTC) #20
rmcilroy
6 years, 9 months ago (2014-03-21 12:53:25 UTC) #21
Message was sent while issue was closed. 
Committed patchset #3 manually as r169734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698