Create recipe to run find_annotated_tests.py periodically

scripts/slave/recipe_modules/chromium_tests/steps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import datetime
 import re
 import string
 
 
 class Test(object):
   """
   Base class for tests that can be retried after deapplying a previously
   applied patch.
   """
 
@@ skipping 1840 matching lines @@
   @staticmethod
   def compile_targets(api):
     """List of compile targets needed by this test."""
     return []
 
   def run(self, api, suffix, test_filter=None):
     api.chromium_android.coverage_report(upload=False)
     api.chromium_android.get_changed_lines_for_revision()
     api.chromium_android.incremental_coverage_report()
 
+class FindAnnotatedTest(Test):

[jbudorick, 2016/06/28 10:37:19]

Hm, I should've been more clear. This isn't what I meant, either. I'm instead
wondering about the feasibility of implementing this as a ScriptTest that gets
specified in src/testing/buildbot/chromium.fyi.json.

[mikecase (-- gone --), 2016/06/28 22:41:31]

After talking with Yoland it seems like making it a script test isnt the best
idea. This needs to upload some things to Google Storage and clean up temp files
after the script runs. Moving these things into a script would duplicate code
(we already have recipe APIs to do these things) and just make it more complex.

+  test_apks = {

[mikecase (-- gone --), 2016/06/28 22:41:31]

eh, _TEST_APKS probably. or _DEFAULT_TEST_APKS

[the real yoland, 2016/07/08 19:02:20]

Done

+      'android_webview_test_apk': 'AndroidWebViewTest',
+      'blimp_test_apk': 'BlimpTest',
+      'chrome_public_test_apk': 'ChromePublicTest',
+      'chrome_sync_shell_test_apk': 'ChromeSyncShellTest',
+      'content_shell_test_apk': 'ContentShellTest',
+      'system_webview_shell_layout_test_apk': 'SystemWebViewShellLayoutTest',
+  }
+
+  @staticmethod
+  def compile_targets(api):
+    return FindAnnotatedTest.test_apks.keys()
+
+  def run(self, api, suffix, test_filter=None):
+    try:
+      temp_output_dir = api.path.mkdtemp('annotated_tests_json_temp')
+      timestamp = datetime.datetime.utcnow()
+      timestamp_string = timestamp.strftime('%Y%m%dT%H%M%S')
+
+      api.python(
+          'run find_annotated_tests.py',
+          api.path['checkout'].join(
+              'tools', 'android', 'find_annotated_tests.py'),
+          args = [
+              '--test-apks', ' '.join(FindAnnotatedTest.test_apks.values()),

[mikecase (-- gone --), 2016/06/28 22:41:31]

How does your script find the test apks? Should you be passing the fullpaths to
the apks to this script?

+              '--apk-output-dir', api.chromium.output_dir, 
+              '--json-output-dir', temp_output_dir,
+              '--timestamp-string', timestamp_string,
+              '-v'])
+      api.gsutil.upload(
+          temp_output_dir.join(
+              '%s-android-chrome.json' % timestamp_string),
+          'chromium-annotated-tests', 'android')
+    finally:
+      api.file.rmtree('Delete temp out directory', temp_output_dir)

[Paweł Hajdan Jr., 2016/07/04 10:42:42]

Could you use tempfile.temp_dir context manager from the recipe engine?

[the real yoland, 2016/07/13 20:36:12]

Done

 
 GOMA_TESTS = [
   GTestTest('base_unittests'),
   GTestTest('content_unittests'),
 ]