Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: infra/tools/cq_stats/cq_stats.py

Issue 2063293002: Actually fix stray threads in cq_stats tests (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/tools/cq_stats/cq_stats.py
diff --git a/infra/tools/cq_stats/cq_stats.py b/infra/tools/cq_stats/cq_stats.py
index 9b6eecfdabc9ba4c2233171ce723c9002b984911..f2a7d3bb526ebd4592d67354be6b497cb332f9ea 100755
--- a/infra/tools/cq_stats/cq_stats.py
+++ b/infra/tools/cq_stats/cq_stats.py
@@ -595,6 +595,7 @@ def derive_stats(args, begin_date, init_stats=None):
pool = ThreadPool(min(args.thread_pool, len(raw_patches)))
iterable = pool.imap_unordered(get_patch_stats, raw_patches)
pool.close()
+ pool.join()
patches, issues = set(), set()
for patch_id, pstats in iterable:
@@ -1057,6 +1058,8 @@ def print_flakiness_stats(args, stats):
pool = ThreadPool(min(args.thread_pool, len(stats['patch_stats'].keys())))
iterable = pool.imap_unordered(
get_flakiness_stats, stats['patch_stats'].keys())
+ pool.close()
+ pool.join()
try_job_stats = {}
for result in iterable:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698