Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2063283002: Revert "Do not suppress referrers for '<a ... rel="noopener">'." on M52 branch (Closed)

Created:
4 years, 6 months ago by dmazzoni
Modified:
4 years, 6 months ago
Reviewers:
Mike West, hcarmona
CC:
chromium-reviews, tyoshino+watch_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, loading-reviews_chromium.org, darin-cc_chromium.org, gavinp+loader_chromium.org, blink-reviews, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Revert "Do not suppress referrers for '<a ... rel="noopener">'." on M52 branch The current implementation of 'noopener' correctly split the referrer and opener states in Blink, but missed a spot higher up the stack where the two were still conflated. This patch fixes that issue, adds tests to ensure we don't regress, and refactors the Blink-side code a bit so that we're no longer passing the data around twice. BUG=618532, 619856 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://chromium.googlesource.com/chromium/src/+/f7939c2fff08f8f0d2700eea46ef94c57a985166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -40 lines) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 3 chunks +1 line, -21 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.cpp View 7 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
dmazzoni
4 years, 6 months ago (2016-06-14 20:17:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f7939c2fff08f8f0d2700eea46ef94c57a985166.

Powered by Google App Engine
This is Rietveld 408576698