base/strings/string_number_conversions.cc - Issue 2063273002: XXX: not-working std::strtod for xref to https://codereview.chromium.org/2044643005/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_number_conversions.cc

Issue 2063273002: XXX: not-working std::strtod for xref to https://codereview.chromium.org/2044643005/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/strings/string_number_conversions.cc

diff --git a/base/strings/string_number_conversions.cc b/base/strings/string_number_conversions.cc

index f4cf6ec521f1cd0d1c663df54bc792a67a76bc3c..6c274d41a3757535910cf2c7e0025e3387212ed4 100644

--- a/base/strings/string_number_conversions.cc

+++ b/base/strings/string_number_conversions.cc

@@ -420,7 +420,7 @@ bool StringToDouble(const std::string& input, double* output) {

ScopedClearErrno clear_errno;

char* endptr = NULL;

- *output = dmg_fp::strtod(input.c_str(), &endptr);

+ *output = std::strtod(input.c_str(), &endptr);

// Cases to return false:

// - If errno is ERANGE, there was an overflow or underflow.

« no previous file with comments | « no previous file | base/strings/string_number_conversions_unittest.cc » ('j') | no next file with comments »