Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: tools/gn/xcode_writer.h

Issue 2063243002: [GN] Add deployment target in generated project. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@{1}
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/xcode_writer.cc » ('j') | tools/gn/xcode_writer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/xcode_writer.h
diff --git a/tools/gn/xcode_writer.h b/tools/gn/xcode_writer.h
index 8c4e3040a0932af290c44a27b57cefa650a5c66f..d618ede2f75b3170819de27b171fc570bee537b2 100644
--- a/tools/gn/xcode_writer.h
+++ b/tools/gn/xcode_writer.h
@@ -28,11 +28,6 @@ class FilePath;
class XcodeWriter {
public:
- enum TargetOsType {
- WRITER_TARGET_OS_IOS,
- WRITER_TARGET_OS_MACOS,
- };
-
// Writes Xcode workspace and project files.
//
// |workspace_name| is the optional name of the workspace file name ("all"
@@ -55,6 +50,12 @@ class XcodeWriter {
XcodeWriter(const std::string& name);
~XcodeWriter();
+ // Returns the attributes to use for the projects.
+ static bool GetProjectsAttributes(
+ const BuildSettings* build_settings,
+ PBXAttributes* attributes,
+ Err* err);
+
// Filters the list of targets to only return the targets with artifacts
// usable from Xcode (mostly application bundles). On failure populate |err|
// and return false.
@@ -73,8 +74,7 @@ class XcodeWriter {
const std::string& config_name,
const std::string& root_target,
const std::string& ninja_extra_args,
- const BuildSettings* build_settings,
- TargetOsType target_os);
+ const BuildSettings* build_settings);
// Generates the "sources.xcodeproj" project that reference all source
// files to allow Xcode to index them.
@@ -82,8 +82,7 @@ class XcodeWriter {
const SourceDir& root_build_dir,
const PBXAttributes& attributes,
const std::string& source_path,
- const std::string& config_name,
- TargetOsType target_os);
+ const std::string& config_name);
bool WriteFiles(const BuildSettings* build_settings, Err* err);
bool WriteProjectFile(const BuildSettings* build_settings,
« no previous file with comments | « no previous file | tools/gn/xcode_writer.cc » ('j') | tools/gn/xcode_writer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698