Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2063223003: Type parameters and class members must not conflict (Closed)

Created:
4 years, 6 months ago by hausner
Modified:
4 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Paul Berry
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Type parameter and class name must not conflict Implement missing name conflict check. BUG=14513 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/42f5c25fa5686e1613cf8ae5ee875b41680ec091

Patch Set 1 #

Patch Set 2 : wip #

Patch Set 3 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M runtime/vm/parser.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M tests/co19/co19-co19.status View 1 2 1 chunk +7 lines, -8 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
hausner
4 years, 6 months ago (2016-06-15 20:07:05 UTC) #4
regis
LGTM
4 years, 6 months ago (2016-06-15 20:21:14 UTC) #5
hausner
4 years, 6 months ago (2016-06-15 20:28:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
42f5c25fa5686e1613cf8ae5ee875b41680ec091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698