Add media::VideoEncodeAccelerator with WebRTC integration

content/common/gpu/media/gpu_video_encode_accelerator.cc

Index: content/common/gpu/media/gpu_video_encode_accelerator.cc
diff --git a/content/common/gpu/media/gpu_video_encode_accelerator.cc b/content/common/gpu/media/gpu_video_encode_accelerator.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1c88c1c3eef2cee5a6a959c857461d24a85ee3d7
--- /dev/null
+++ b/content/common/gpu/media/gpu_video_encode_accelerator.cc
@@ -0,0 +1,240 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/common/gpu/media/gpu_video_encode_accelerator.h"
+
+#include "base/callback.h"
+#include "base/logging.h"
+#include "base/memory/shared_memory.h"
+#include "base/message_loop/message_loop_proxy.h"
+#include "content/common/gpu/gpu_channel.h"
+#include "content/common/gpu/gpu_messages.h"
+#include "ipc/ipc_message_macros.h"
+#include "media/base/video_frame.h"
+
+namespace content {
+
+GpuVideoEncodeAccelerator::GpuVideoEncodeAccelerator(GpuChannel* gpu_channel,
+                                                     int32 route_id)
+    : weak_this_factory_(this),
+      channel_(gpu_channel),
+      route_id_(route_id),
+      input_format_(media::VideoFrame::INVALID),
+      output_buffer_size_(0) {}
+
+GpuVideoEncodeAccelerator::~GpuVideoEncodeAccelerator() {
+  if (encoder_)
+    encoder_.release()->Destroy();
+}
+
+bool GpuVideoEncodeAccelerator::OnMessageReceived(const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(GpuVideoEncodeAccelerator, message)
+    IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_Initialize, OnInitialize)
+    IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_Encode, OnEncode)
+    IPC_MESSAGE_HANDLER(AcceleratedVideoEncoderMsg_UseOutputBitstreamBuffer,
+                        OnUseOutputBitstreamBuffer)
+    IPC_MESSAGE_HANDLER(
+        AcceleratedVideoEncoderMsg_RequestEncodingParametersChange,
+        OnRequestEncodingParametersChange)
+    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+  return handled;
+}
+
+void GpuVideoEncodeAccelerator::OnChannelError() {
+  NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+  if (channel_)
+    channel_ = NULL;
+}
+
+void GpuVideoEncodeAccelerator::NotifyInitializeDone() {
+  Send(new AcceleratedVideoEncoderHostMsg_NotifyInitializeDone(route_id_));
+}
+
+void GpuVideoEncodeAccelerator::RequireBitstreamBuffers(
+    int input_count,
+    const gfx::Size& input_coded_size,
+    size_t output_buffer_size) {
+  Send(new AcceleratedVideoEncoderHostMsg_RequireBitstreamBuffers(
+      route_id_, input_count, input_coded_size, output_buffer_size));
+  input_coded_size_ = input_coded_size;
+  output_buffer_size_ = output_buffer_size;
+}
+
+void GpuVideoEncodeAccelerator::BitstreamBufferReady(int32 bitstream_buffer_id,
+                                                     size_t payload_size,
+                                                     bool key_frame) {
+  Send(new AcceleratedVideoEncoderHostMsg_BitstreamBufferReady(
+      route_id_, bitstream_buffer_id, payload_size, key_frame));
+}
+
+void GpuVideoEncodeAccelerator::NotifyError(
+    media::VideoEncodeAccelerator::Error error) {
+  Send(new AcceleratedVideoEncoderHostMsg_NotifyError(route_id_, error));
+}
+
+// static
+std::vector<media::VideoEncodeAccelerator::SupportedProfile>
+GpuVideoEncodeAccelerator::GetSupportedProfiles() {
+  std::vector<media::VideoEncodeAccelerator::SupportedProfile> profiles;
+
+  // TODO(sheu): return platform-specific profiles.
+  return profiles;
+}
+
+void GpuVideoEncodeAccelerator::CreateEncoder() {
+  // TODO(sheu): actual create the encoder.
+}
+
+void GpuVideoEncodeAccelerator::OnInitialize(
+    media::VideoFrame::Format input_format,
+    const gfx::Size& input_visible_size,
+    media::VideoCodecProfile output_profile,
+    int32 initial_bitrate) {

[Chris Evans, 2013/08/11 22:05:41]

Input parameter validation.
- What about a negative, zero or crazy-bit initial_bitrate.
- AFAIK, we _still_ don't have generic gfx::Size validation, so we should
probably check for integer overflow in width * height.
- What about unrecognized input_format or output_profile?

[sheu, 2013/08/12 19:48:16]

initial_bitrate is made unsigned now.  If zero or crazy, that should be up to
the encoder to decide (since different encoders may have different ideas of
crazy).

I'll check input_visible_size.

input_format and output_profile being unrecognized values again should be
handled by the encoder, since different encoders may support different formats. 
Internally, we make sure to handle bad values for input_format_ when used (e.g.
in OnEncode()).

+  DVLOG(2) << "GpuVideoEncodeAccelerator::OnInitialize(): "
+              "input_format=" << input_format
+           << ", input_visible_size=" << input_visible_size.ToString()
+           << ", output_profile=" << output_profile
+           << ", initial_bitrate=" << initial_bitrate;
+  DCHECK(!encoder_);
+
+  CreateEncoder();
+  if (!encoder_) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnInitialize(): VEA creation "
+                   "failed";
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+  encoder_->Initialize(
+      input_format, input_visible_size, output_profile, initial_bitrate);
+  input_format_ = input_format;
+  input_visible_size_ = input_visible_size;
+}
+
+void GpuVideoEncodeAccelerator::OnEncode(int32 frame_id,
+                                         base::SharedMemoryHandle buffer_handle,
+                                         uint32 buffer_size,
+                                         bool force_keyframe) {
+  DVLOG(3) << "GpuVideoEncodeAccelerator::OnEncode(): frame_id=" << frame_id
+           << ", buffer_size=" << buffer_size
+           << ", force_keyframe=" << force_keyframe;
+  if (!encoder_)
+    return;
+  if (frame_id < 0) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncode(): invalid frame_id="
+                << frame_id;
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+
+  scoped_ptr<base::SharedMemory> shm(
+      new base::SharedMemory(buffer_handle, true));
+  if (!shm->Map(buffer_size)) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncode(): "
+                   "could not map frame_id=" << frame_id;
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+
+  scoped_refptr<media::VideoFrame> frame;
+  switch (input_format_) {
+    case media::VideoFrame::I420: {
+      if (buffer_size <
+          static_cast<size_t>(input_coded_size_.GetArea() * 3 / 2)) {

[Chris Evans, 2013/08/11 22:05:41]

Where does input_coded_size_ come from? Two possible integer overflows here?

[sheu, 2013/08/12 19:48:16]

input_coded_size_ is reported from the VideoEncodeAccelerator instance within
this process, in RequireBitstreamBuffers.  If the instance reports an
overflowing size, it's got problems too.

+        DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnEncode(): "
+                       "buffer too small for frame_id=" << frame_id;
+        NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+        return;
+      }
+      uint8* data = reinterpret_cast<uint8*>(shm->memory());
+      frame = media::VideoFrame::WrapExternalYuvData(
+          media::VideoFrame::I420,
+          input_coded_size_,
+          gfx::Rect(input_visible_size_),
+          input_visible_size_,
+          input_coded_size_.width(),
+          input_coded_size_.width() / 2,
+          input_coded_size_.width() / 2,
+          data,
+          data + input_coded_size_.GetArea(),
+          data + (input_coded_size_.GetArea() * 5 / 4),
+          base::TimeDelta(),
+          buffer_handle,
+          // It's turtles all the way down...
+          base::Bind(base::IgnoreResult(&base::MessageLoopProxy::PostTask),
+                     base::MessageLoopProxy::current(),
+                     FROM_HERE,
+                     base::Bind(&GpuVideoEncodeAccelerator::EncodeFrameFinished,
+                                weak_this_factory_.GetWeakPtr(),
+                                frame_id,
+                                base::Passed(&shm))));
+      break;
+    }
+    default:
+      NOTREACHED();
+      NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+      return;
+  }
+
+  encoder_->Encode(frame, force_keyframe);
+}
+
+void GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(
+    int32 buffer_id,
+    base::SharedMemoryHandle buffer_handle,
+    uint32 buffer_size) {
+  DVLOG(3) << "GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(): "
+              "buffer_id=" << buffer_id
+           << ", buffer_size=" << buffer_size;
+  if (!encoder_)
+    return;
+  if (buffer_id < 0) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(): "
+                   "invalid buffer_id=" << buffer_id;
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+  if (buffer_size < output_buffer_size_) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::OnUseOutputBitstreamBuffer(): "
+                   "buffer too small for buffer_id=" << buffer_id;
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+  encoder_->UseOutputBitstreamBuffer(
+      media::BitstreamBuffer(buffer_id, buffer_handle, buffer_size));
+}
+
+void GpuVideoEncodeAccelerator::OnRequestEncodingParametersChange(
+    int32 bitrate,
+    uint32 framerate) {

[Chris Evans, 2013/08/11 22:05:41]

Parameter validation.
Also, why is bitrate signed? Does a negative bitrate make any sense? If not, an
unsigned type is much safer.

[sheu, 2013/08/12 19:48:16]

Bitrate is unsigned to allow negative values as special values.  We're not using
that facility though, so for the purposes of safety I suppose I could change
this.

I'm expecting implementers of the VideoEncodeAccelerator interface to validate
parameters, since requirements may differ.

+  DVLOG(2) << "GpuVideoEncodeAccelerator::OnRequestEncodingParametersChange(): "
+              "bitrate=" << bitrate
+           << ", framerate=" << framerate;
+  if (!encoder_)
+    return;
+  encoder_->RequestEncodingParametersChange(bitrate, framerate);
+}
+
+void GpuVideoEncodeAccelerator::EncodeFrameFinished(
+    int32 frame_id,
+    scoped_ptr<base::SharedMemory> shm) {
+  Send(new AcceleratedVideoEncoderHostMsg_NotifyInputDone(route_id_, frame_id));
+  // Just let shm fall out of scope.
+}
+
+void GpuVideoEncodeAccelerator::Send(IPC::Message* message) {
+  if (!channel_) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::Send(): no channel";
+    delete message;
+    return;
+  } else if (!channel_->Send(message)) {
+    DLOG(ERROR) << "GpuVideoEncodeAccelerator::Send(): sending failed: "
+                   "message->type()=" << message->type();
+    NotifyError(media::VideoEncodeAccelerator::kPlatformFailureError);
+    return;
+  }
+}
+
+}  // namespace content