Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 206313004: DevTools: Rename WebInspector.DOMAgent into WebInspector.DOMModel (Closed)

Created:
6 years, 9 months ago by sergeyv
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: Rename WebInspector.DOMAgent into WebInspector.DOMModel BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169928

Patch Set 1 #

Patch Set 2 : rebase on master #

Patch Set 3 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -1962 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/inspector/layers-test.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector/modify-cross-domain-rule.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/dom-agent-query-selector.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/dom-search-crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/edit-style-attribute.html View 2 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/inspector/elements/edit-style-attribute-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-css-path.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-panel-rewrite-href.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/elements-panel-search.html View 3 chunks +21 lines, -21 lines 0 comments Download
M LayoutTests/inspector/elements/insert-node.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/inspect-mode-shadow-text.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/inspect-pointer-events-none.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/inspect-pseudo-element.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/node-xpath.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/perform-undo-undo.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/resolve-alien-node.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/resources/iframe-load-event-iframe.js View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/set-attribute.html View 7 chunks +13 lines, -13 lines 0 comments Download
M LayoutTests/inspector/elements/set-outer-html-test.js View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/elements/styles/perform-undo-perform-of-mergable-action.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/pseudo-elements.html View 3 chunks +11 lines, -11 lines 0 comments Download
M LayoutTests/inspector/elements/styles/style-update-during-selector-edit.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/undo-add-new-rule.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-add-property.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-add-rule-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/undo-change-property.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-property-toggle.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/elements/styles/undo-set-selector-text.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/layers/layer-compositing-reasons.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/inspector/first-open-elements.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/inspector/inspector-startup-time.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/devtools.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/AuditRules.js View 9 chunks +13 lines, -13 lines 0 comments Download
M Source/devtools/front_end/CSSStyleModel.js View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/ConsoleViewMessage.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
D Source/devtools/front_end/DOMAgent.js View 1 2 1 chunk +0 lines, -1689 lines 0 comments Download
M Source/devtools/front_end/DOMBreakpointsSidebarPane.js View 3 chunks +3 lines, -3 lines 0 comments Download
A + Source/devtools/front_end/DOMModel.js View 1 2 55 chunks +70 lines, -70 lines 0 comments Download
M Source/devtools/front_end/DOMPresentationUtils.js View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ElementsPanel.js View 1 15 chunks +19 lines, -19 lines 0 comments Download
M Source/devtools/front_end/ElementsTreeOutline.js View 1 2 8 chunks +14 lines, -14 lines 0 comments Download
M Source/devtools/front_end/EventListenersSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ExtensionAuditCategory.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/InspectElementModeController.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/LayerTree.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/LayerTreeModel.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/Layers3DView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/LayersPanel.js View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/Main.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/MetricsSidebarPane.js View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/ObjectPopoverHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/OverridesSupport.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/PlatformFontsSidebarPane.js View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/RemoteObject.js View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ScreencastView.js View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/StylesSidebarPane.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/Target.js View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/TimelineUIUtils.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
sergeyv
6 years, 9 months ago (2014-03-20 15:54:12 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-24 12:17:38 UTC) #2
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-24 14:48:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206313004/20001
6 years, 9 months ago (2014-03-24 14:48:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 15:54:06 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/devtools/front_end/RemoteObject.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-24 15:54:07 UTC) #6
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-24 17:07:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206313004/40001
6 years, 9 months ago (2014-03-24 17:07:32 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:09:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-24 17:09:14 UTC) #10
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-24 18:55:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206313004/40001
6 years, 9 months ago (2014-03-24 18:56:02 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 19:24:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-24 19:24:59 UTC) #14
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-24 20:52:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206313004/40001
6 years, 9 months ago (2014-03-24 20:52:44 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 21:25:37 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-24 21:25:37 UTC) #18
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-25 08:38:14 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206313004/40001
6 years, 9 months ago (2014-03-25 08:38:19 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 09:40:46 UTC) #21
Message was sent while issue was closed.
Change committed as 169928

Powered by Google App Engine
This is Rietveld 408576698