Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2063113002: [mojo-edk] Reset Port::send_on_proxy_removal after sending message. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Reset Port::send_on_proxy_removal after sending message. If two threads try to call Node::MaybeRemoveProxy_Locked and both end up trying to send the proxy removal message, the second attempt will result in a null message since the first one moved it into ForwardMessage. BUG=619522 Committed: https://crrev.com/2bb5f5da90bf2584f7f971fed962ce6a564bc3be Cr-Commit-Position: refs/heads/master@{#399664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M mojo/edk/system/node_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/ports/node.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Anand Mistry (off Chromium)
4 years, 6 months ago (2016-06-14 05:04:20 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-14 05:06:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063113002/1
4 years, 6 months ago (2016-06-14 05:08:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/238575)
4 years, 6 months ago (2016-06-14 06:36:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063113002/1
4 years, 6 months ago (2016-06-14 06:43:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 07:24:13 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 07:24:15 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 07:27:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bb5f5da90bf2584f7f971fed962ce6a564bc3be
Cr-Commit-Position: refs/heads/master@{#399664}

Powered by Google App Engine
This is Rietveld 408576698