Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2063103002: Fixed overlapping subtle notifications on Mac. (Closed)

Created:
4 years, 6 months ago by Matt Giuca
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fixed overlapping subtle notifications on Mac. Can happen when a fullscreen/pointer-lock bubble and a new-back-shortcut bubble are visible at the same time. Now the new bubble will dismiss the old bubble (which is the behaviour on Views platforms). BUG=615971 Review-Url: https://codereview.chromium.org/2028963002 Cr-Commit-Position: refs/heads/master@{#397973} (cherry picked from commit e1ec367efc1eeae3ba9fcb7309d4e0be44e6c44f) Committed: https://chromium.googlesource.com/chromium/src/+/011b06586201c9bdcd9d1959455a0454ac028be2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Matt Giuca
4 years, 6 months ago (2016-06-14 04:11:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
011b06586201c9bdcd9d1959455a0454ac028be2 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698