Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2063073003:
Modified WPTServeExpectations for test failures on "WebKit Linux - WPTServe" (Closed)
DescriptionModified WPTServeExpectations for test failures on "WebKit Linux - WPTServe"
These test failed on the "WebKit Linux - WPT Serve" builder with --enable-wptserve.
Added to the WPTServeExpectations file to allow bot to continue running and find more bugs/errors.
BUG=619746
Committed: https://crrev.com/46872e427b97477ab233fc4f47a70620272ff006
Cr-Commit-Position: refs/heads/master@{#399763}
Patch Set 1 #
Total comments: 1
Patch Set 2 : changed comment in WPTServeExpectations #Messages
Total messages: 19 (7 generated)
dcampb@google.com changed reviewers: + dpranke@chromium.org, qyearsley@chromium.org, tkent@chromium.org
I think this is what we want to do -- can Kent or Dirk confirm? Nits about the CL description formatting: - The CL title should match the first line of the description. - The CL title generally starts with a capital letter. - There should be a blank line between the first line and the rest. - There should be a blank line before the BUG= part. https://codereview.chromium.org/2063073003/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/WPTServeExpectations (right): https://codereview.chromium.org/2063073003/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/WPTServeExpectations:54: # These tests timeout with --enable-wptserve enabled on chromium_fyi builder (linux) This is probably not related to chromium_fyi specifically; probably no need to mention chromium_fyi specifically. Note: on my workstation, imported/wpt/html/semantics/document-metadata/the-link-element/link-style-error-01.html times out when I use --enable-wptserve, but the other two don't; it may be interesting to see which ones time out on your linux workstation -- are they the same ones as here?
Description was changed from ========== modified expectations for test that failed on wptserve bot These test failed on the "WebKit Linux - WPT Serve" builder with --enable-wptserve. Added to the WPTExpectations file to allow bot to continue running and find more bugs/errors. BUG=619746 ========== to ========== Modified WPTExpectations for test failures on "WebKit Linux - WPTServe" These test failed on the "WebKit Linux - WPT Serve" builder with --enable-wptserve. Added to the WPTExpectations file to allow bot to continue running and find more bugs/errors. BUG=619746 ==========
On 2016/06/14 at 00:13:53, qyearsley wrote: > I think this is what we want to do -- can Kent or Dirk confirm? > > Nits about the CL description formatting: > - The CL title should match the first line of the description. > - The CL title generally starts with a capital letter. > - There should be a blank line between the first line and the rest. > - There should be a blank line before the BUG= part. > > https://codereview.chromium.org/2063073003/diff/1/third_party/WebKit/LayoutTe... > File third_party/WebKit/LayoutTests/WPTServeExpectations (right): > > https://codereview.chromium.org/2063073003/diff/1/third_party/WebKit/LayoutTe... > third_party/WebKit/LayoutTests/WPTServeExpectations:54: # These tests timeout with --enable-wptserve enabled on chromium_fyi builder (linux) > This is probably not related to chromium_fyi specifically; probably no need to mention chromium_fyi specifically. > > Note: on my workstation, imported/wpt/html/semantics/document-metadata/the-link-element/link-style-error-01.html times out when I use --enable-wptserve, but the other two don't; it may be interesting to see which ones time out on your linux workstation -- are they the same ones as here? "../pointerevent_button_attribute_mouse-manual.html" returned back missing for me. "../svg-in-iframe-fixed.html" ran as expected. "../link-style-error-01.html" timed out. not sure why that is though. the stdio logs for the webkit_tests gave back the results in the cl, which is why i labeled them accordingly.
Description was changed from ========== Modified WPTExpectations for test failures on "WebKit Linux - WPTServe" These test failed on the "WebKit Linux - WPT Serve" builder with --enable-wptserve. Added to the WPTExpectations file to allow bot to continue running and find more bugs/errors. BUG=619746 ========== to ========== Modified WPTServeExpectations for test failures on "WebKit Linux - WPTServe" These test failed on the "WebKit Linux - WPT Serve" builder with --enable-wptserve. Added to the WPTServeExpectations file to allow bot to continue running and find more bugs/errors. BUG=619746 ==========
On 2016/06/14 at 00:13:53, qyearsley wrote: > I think this is what we want to do -- can Kent or Dirk confirm? I think so too.
lgtm
The CQ bit was checked by dcampb@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063073003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dcampb@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063073003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Modified WPTServeExpectations for test failures on "WebKit Linux - WPTServe" These test failed on the "WebKit Linux - WPT Serve" builder with --enable-wptserve. Added to the WPTServeExpectations file to allow bot to continue running and find more bugs/errors. BUG=619746 ========== to ========== Modified WPTServeExpectations for test failures on "WebKit Linux - WPTServe" These test failed on the "WebKit Linux - WPT Serve" builder with --enable-wptserve. Added to the WPTServeExpectations file to allow bot to continue running and find more bugs/errors. BUG=619746 Committed: https://crrev.com/46872e427b97477ab233fc4f47a70620272ff006 Cr-Commit-Position: refs/heads/master@{#399763} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/46872e427b97477ab233fc4f47a70620272ff006 Cr-Commit-Position: refs/heads/master@{#399763}
Message was sent while issue was closed.
lgtm |
