Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2063013005: Revert of [heap] Add page evacuation mode for new->new (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Add page evacuation mode for new->new (patchset #18 id:440001 of https://codereview.chromium.org/1957323003/ ) Reason for revert: Fragmentation of LABs could result in increasing memory usage (pages) instead of shrinking. BUG=chromium:620320 LOG=N Original issue's description: > [heap] Add page evacuation mode for new->new > > Adds an evacuation mode that allows moving pages within new space without > copying objects. > > Basic idea: > a) Move page within new space > b) Sweep page to make iterable and process ArrayBuffers > c) Finish sweep till next scavenge > > Threshold is currently 70% live bytes, i.e., the same threshold we use > to determine fragmented pages. > > BUG=chromium:581412 > LOG=N > CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel > > Committed: https://crrev.com/49b23201671b25092a3c22eb85783f39b95a5f87 > Cr-Commit-Position: refs/heads/master@{#36990} TBR=ulan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:581412 Committed: https://crrev.com/2263ee9bf4e5aa341cbac547add68a2105963477 Cr-Commit-Position: refs/heads/master@{#37042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -462 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 4 chunks +2 lines, -4 lines 0 comments Download
M src/heap/mark-compact.cc View 24 chunks +165 lines, -256 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +6 lines, -17 lines 0 comments Download
M src/heap/spaces.cc View 3 chunks +16 lines, -53 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +50 lines, -0 lines 0 comments Download
D test/cctest/heap/test-page-promotion.cc View 1 chunk +0 lines, -129 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Lippautz
Created Revert of [heap] Add page evacuation mode for new->new
4 years, 6 months ago (2016-06-16 16:24:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063013005/1
4 years, 6 months ago (2016-06-16 16:24:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 16:52:52 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 16:55:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2263ee9bf4e5aa341cbac547add68a2105963477
Cr-Commit-Position: refs/heads/master@{#37042}

Powered by Google App Engine
This is Rietveld 408576698