src/wasm/ast-decoder.cc - Issue 2063013004: [wasm] Disassemble wasm code from script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/ast-decoder.cc

Issue 2063013004: [wasm] Disassemble wasm code from script (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-frame-inspection

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/ast-decoder.cc

diff --git a/src/wasm/ast-decoder.cc b/src/wasm/ast-decoder.cc

index 9b99ec01fc139da0dfc110c1bf701d46daef2021..e014dd1ed1c71f64de8e62cd5f242961bee9798a 100644

--- a/src/wasm/ast-decoder.cc

+++ b/src/wasm/ast-decoder.cc

@@ -1577,6 +1577,7 @@ bool PrintAst(base::AccountingAllocator* allocator, const FunctionBody& body,

os << " " << count << " " << WasmOpcodes::TypeName(type);

}

os << std::endl;

+ ++line_nr;

for (const byte* locals = body.start; locals < pc; locals++) {

os << (locals == body.start ? "0x" : " 0x") << AsHex(*locals, 2) << ",";