Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: src/debug/debug.cc

Issue 2063013004: [wasm] Disassemble wasm code from script (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-frame-inspection
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/debug/debug.js » ('j') | src/debug/debug.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index 7287ceb1865ab214ad49bfbfd08d2a87f13b8733..2933b8b92fbba92c83dcf87485013a650ad4c083 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -809,7 +809,8 @@ bool Debug::SetBreakPointForScript(Handle<Script> script,
int* source_position,
BreakPositionAlignment alignment) {
if (script->type() == Script::TYPE_WASM) {
- // TODO(clemensh): set breakpoint for wasm.
+ return wasm::GetDebugInfo(JSObject::cast(script->wasm_object()))
+ ->SetBreakPoint(*source_position);
Yang 2016/06/17 18:16:31 The reason we pass in a pointer for source_positio
Clemens Hammacher 2016/06/24 15:12:33 No, the called function just returned false. I thu
}
HandleScope scope(isolate_);
« no previous file with comments | « no previous file | src/debug/debug.js » ('j') | src/debug/debug.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698