Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2063013002: Revert of telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops (Closed)

Created:
4 years, 6 months ago by Zhen Wang
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix-chalkboard-recording
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops (patchset #2 id:20001 of https://codereview.chromium.org/1994653004/ ) Reason for revert: smoothness.tough_path_rendering_cases fails on Android Nexus5 Perf (1) and Android Nexus7v2 Perf (1) bots. Seems clear that this CL causes it. BUG=619716 Original issue's description: > telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops > > Stop measuring tough_path_rendering_cases chalkboard test-case after the > page stops its "benchmark" and presents the results. > > The page used to wait 20s. On my desktop it runs <10s and on my > particular Android device, ~17s. > > This avoids measuring the page after it stops updating. > > Committed: https://crrev.com/6a26af29d26f974d63d78f2a29757f0f8f6162f4 > Cr-Commit-Position: refs/heads/master@{#399432} TBR=nednguyen@google.com,senorblanco@google.com,senorblanco@chromium.org,kkinnunen@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b51973cd26598a234c7bd97a9909bdcc30a81003 Cr-Commit-Position: refs/heads/master@{#399562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M tools/perf/page_sets/tough_path_rendering_cases.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Zhen Wang
Created Revert of telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops
4 years, 6 months ago (2016-06-13 21:55:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063013002/1
4 years, 6 months ago (2016-06-13 21:55:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 21:56:28 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 21:56:32 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:57:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b51973cd26598a234c7bd97a9909bdcc30a81003
Cr-Commit-Position: refs/heads/master@{#399562}

Powered by Google App Engine
This is Rietveld 408576698