content/public/common/manifest.cc - Issue 2063003003: Implement "scope" Web Manifest parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/manifest.cc

Issue 2063003003: Implement "scope" Web Manifest parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'webapk_manifest_scope00' into webapk_manifest_scope0 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/manifest.cc

diff --git a/content/public/common/manifest.cc b/content/public/common/manifest.cc

index 86a6d41d4c3a44a441772eac8a0e7ce6360f13f8..599cb6991d92d6b4a0f0878e0e77d0c4f126752d 100644

--- a/content/public/common/manifest.cc

+++ b/content/public/common/manifest.cc

@@ -44,6 +44,7 @@ bool Manifest::IsEmpty() const {

return name.is_null() &&

short_name.is_null() &&

start_url.is_empty() &&

+ scope.is_empty() &&

mlamouri (slow - plz ping) 2016/06/21 13:48:54 ditto

display == blink::WebDisplayModeUndefined &&

orientation == blink::WebScreenOrientationLockDefault &&

icons.empty() &&