Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2062993003: Add wrapper script for GPU integration tests, supporting sharding. (Closed)

Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add wrapper script for GPU integration tests, supporting sharding. Add isolates for the new test harness. Once all of the GPU tests are switched to the new harness, the old one, and its wrapper script, will be deleted. BUG=352807 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/6133d7c8452acc247fc01594b00c774b5c81be31 Cr-Commit-Position: refs/heads/master@{#399808}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -32 lines) Patch
A + chrome/telemetry_gpu_integration_test.isolate View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +33 lines, -0 lines 0 comments Download
M content/test/gpu/run_gpu_integration_test.py View 3 chunks +9 lines, -6 lines 0 comments Download
A + testing/scripts/run_gpu_integration_test_as_googletest.py View 3 chunks +27 lines, -23 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
Ken Russell (switch to Gerrit)
dpranke: please review chrome/test/BUILD.gn and testing/scripts/ vadimsh: please review chrome/telemetry_gpu_integration_test.isolate nednguyen, zmo: please review content/test/gpu/ ...
4 years, 6 months ago (2016-06-14 00:42:29 UTC) #3
Zhenyao Mo
content/gest/gpu lgtm
4 years, 6 months ago (2016-06-14 01:37:04 UTC) #4
nednguyen
content/gest/gpu lgtm
4 years, 6 months ago (2016-06-14 01:50:24 UTC) #5
Vadim Sh.
lgtm
4 years, 6 months ago (2016-06-14 18:06:13 UTC) #6
Dirk Pranke
lgtm to land and make progress. At some point we should sit down so I ...
4 years, 6 months ago (2016-06-14 20:22:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062993003/20001
4 years, 6 months ago (2016-06-14 21:22:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios-device-gn on ...
4 years, 6 months ago (2016-06-14 23:24:35 UTC) #12
Ken Russell (switch to Gerrit)
On 2016/06/14 23:24:35, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-14 23:32:14 UTC) #13
Ken Russell (switch to Gerrit)
On 2016/06/14 23:32:14, Ken Russell wrote: > On 2016/06/14 23:24:35, commit-bot: I haz the power ...
4 years, 6 months ago (2016-06-15 00:34:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062993003/20001
4 years, 6 months ago (2016-06-15 00:35:30 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 00:50:23 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 00:50:28 UTC) #20
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 00:51:55 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6133d7c8452acc247fc01594b00c774b5c81be31
Cr-Commit-Position: refs/heads/master@{#399808}

Powered by Google App Engine
This is Rietveld 408576698