Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Issue 2062913002: [Media Router] Allow casting new media to sink with existing route. (Closed)

Created:
4 years, 6 months ago by btolsch
Modified:
4 years, 6 months ago
Reviewers:
apacible, Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Media Router] Allow casting new media to sink with existing route. This change allows for one button push to stop casting to a sink and then immediately create a new route to the same sink with the selected source. The makes the user experience smoother by not making them stop the current cast and then start a new one manually in two stops. Some shortcomings of this change that will be addressed in the future: - At least for mirroring, it's possible to avoid stopping the route and just switch the stream sources. This probably requires adding a new API to the extension. - The button will currently allow users to re-cast the current source, stopping the current route and starting a new one, even though this isn't necessary. When both the old and new sources are tabs, the tab IDs could be checked, but other cases would have to be handled in MR or the extension. BUG=614144 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2002293003 Cr-Commit-Position: refs/heads/master@{#397457} (cherry picked from commit 4680358215ff217eb6b0073c4be2243738369957)

Patch Set 1 #

Messages

Total messages: 12 (5 generated)
btolsch
Merging to M52, no conflicts. PTAL, thanks!
4 years, 6 months ago (2016-06-13 18:19:16 UTC) #3
apacible
rs lgtm
4 years, 6 months ago (2016-06-13 18:21:00 UTC) #4
apacible
You'll need a histograms owner as well.
4 years, 6 months ago (2016-06-13 18:21:17 UTC) #5
btolsch
+isherman for histograms.xml
4 years, 6 months ago (2016-06-13 18:23:21 UTC) #7
Ilya Sherman
histograms.xml lgtm
4 years, 6 months ago (2016-06-13 21:57:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062913002/1
4 years, 6 months ago (2016-06-13 22:40:15 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 22:42:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698