Remove WebMediaPlayerClient{Impl}::needsWebLayerForVideo() as compositing is always enabled.

Remove WebMediaPlayerClient{Impl}::needsWebLayerForVideo() as compositing is always enabled.

BUG=335345
R=eseidel@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169895

[scherkus (not reviewing), 2014-03-20 17:27:15]

jamesr: here are the blink-side changes for
https://codereview.chromium.org/204463008/ -- please take a look

[scherkus (not reviewing), 2014-03-21 21:25:51]

abarth: can you take a look?

[eseidel, 2014-03-21 21:33:16]

lgtm

So this bool was never read, eh?

[scherkus (not reviewing), 2014-03-21 21:44:56]

On 2014/03/21 21:33:16, eseidel wrote:
> lgtm
> 
> So this bool was never read, eh?

it won't be after https://codereview.chromium.org/204463008/ lands :)

(in practice it was always true, so there's no need to have Chromium-side media
code get all confused about whether it needs a WebLayer or not)

[scherkus (not reviewing), 2014-03-24 20:38:22]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-03-24 20:38:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/206283004/20001

[commit-bot: I haz the power, 2014-03-24 20:40:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 20:40:05]

Try jobs failed on following builders:
  tryserver.blink on win_blink_compile_dbg

[scherkus (not reviewing), 2014-03-24 22:38:32]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-03-24 22:38:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/206283004/20001

[commit-bot: I haz the power, 2014-03-24 22:42:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 22:42:09]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[scherkus (not reviewing), 2014-03-25 00:16:32]

Committed patchset #2 manually as r169895 (presubmit successful).

[tasak, 2014-03-25 05:14:02]

On 2014/03/25 00:16:32, scherkus wrote:
> Committed patchset #2 manually as r169895 (presubmit successful).

FYI.
 blink_android_compile_rel and blink_android_compile_dbg fail:

[11655/15540] CXX
obj/content/browser/loader/content_browser.cross_site_resource_handler.o
FAILED: /mnt/scratch0/b_used/build/goma/gomacc
/mnt/scratch0/b_used/build/slave/blink_android/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-MMD -MF 
obj/content/renderer/media/android/content_renderer.webmediaplayer_android.o.d
-DCONTENT_IMPLEMENTATION 
...snip...
/webmediaplayer_android.cc -o
obj/content/renderer/media/android/content_renderer.webmediaplayer_android.o
../../content/renderer/media/android/webmediaplayer_android.cc: In member
function 'void content::WebMediaPlayerAndroid::CreateWebLayerIfNeeded()':
../../content/renderer/media/android/webmediaplayer_android.cc:993:51: error:
'class blink::WebMediaPlayerClient' has no member named 'needsWebLayerForVideo'
FAILED: /mnt/scratch0/b_used/build/goma/gomacc
/mnt/scratch0/b_used/build/slave/blink_android/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-MMD -MF
 obj/content/renderer/media/content_renderer.webmediaplayer_ms.o.d
-DCONTENT_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS 
...snip...
-fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -Wno-abi  -c
../../content/renderer/media/webmediaplayer_ms.cc -o
obj/content/renderer/media/content_renderer.webmediaplayer_ms.o
../../content/renderer/media/webmediaplayer_ms.cc: In member function 'void
content::WebMediaPlayerMS::OnFrameAvailable(const
scoped_refptr<media::VideoFrame>&)':
../../content/renderer/media/webmediaplayer_ms.cc:416:53: error: 'class
blink::WebMediaPlayerClient' has no member named 'needsWebLayerForVideo'
ninja: build stopped: subcommand failed.

[eustas, 2014-03-25 13:07:22]

The same problem with clang builds.

[scherkus (not reviewing), 2014-03-25 16:17:05]

On 2014/03/25 13:07:22, eustas wrote:
> The same problem with clang builds.

this change assumes chromium is being built with Chromium r259002 or later as
that was the revision I removed all calls to needsWebLayerForVideo() (the code
referenced in those logs doesn't exist anymore)

is it still broken? perhaps the android bots need some sort of DEPS update?