Fixing SkDeferredCanvas::writePixels to trigger appropriate change notifications to SkSurface

Fixing SkDeferredCanvas::writePixels to trigger appropriate change notifications to SkSurface

BUG=crbug.com/256269
TEST=DeferredCanvas unit test, TestDeferredCanvasWritePixelsToSurface
R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10513

[Justin Novosad, 2013-08-01 18:40:12]

PTAL

[Justin Novosad, 2013-08-01 18:48:01]

https://codereview.chromium.org/20628005/diff/1/src/utils/SkDeferredCanvas.cpp
File src/utils/SkDeferredCanvas.cpp (right):

https://codereview.chromium.org/20628005/diff/1/src/utils/SkDeferredCanvas.cp...
src/utils/SkDeferredCanvas.cpp:348: void DeferredDevice::aboutToDraw()
Code factored-out to avoid duplication

https://codereview.chromium.org/20628005/diff/1/tests/DeferredCanvasTest.cpp
File tests/DeferredCanvasTest.cpp (right):

https://codereview.chromium.org/20628005/diff/1/tests/DeferredCanvasTest.cpp#...
tests/DeferredCanvasTest.cpp:15: #include "../src/image/SkSurface_Base.h"
For mocking

https://codereview.chromium.org/20628005/diff/1/tests/DeferredCanvasTest.cpp#...
tests/DeferredCanvasTest.cpp:174: REPORTER_ASSERT(reporter, 1 ==
surface->fDiscardCount);
This one failed before the fix

https://codereview.chromium.org/20628005/diff/1/tests/DeferredCanvasTest.cpp#...
tests/DeferredCanvasTest.cpp:192: REPORTER_ASSERT(reporter, 1 ==
surface->fRetainCount);
This one failed before the fix

[reed1, 2013-08-02 14:51:51]

The mocking may be a little fragile, since that header is by design private, but
lgtm

[Justin Novosad, 2013-08-02 15:36:05]

Committed patchset #1 manually as r10513 (presubmit successful).