Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2062793003: Revert "Revert "Refactor strong mode to use standard Analyzer errors"" (Closed)

Created:
4 years, 6 months ago by Jennifer Messerly
Modified:
4 years, 6 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Refactor strong mode to use standard Analyzer errors"" This reverts commit 228255395e0a6f0b05ad094180f90cea4104e6b1. Rolls the DEPS to a DDC version that works with this change Committed: https://github.com/dart-lang/sdk/commit/3e45751a7bdd7c17840f614015c8eb2633667fd6 Original review CL was: https://codereview.chromium.org/2060013002/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+667 lines, -821 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 2 chunks +129 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 5 chunks +17 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 5 chunks +24 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 2 chunks +0 lines, -3 lines 0 comments Download
A pkg/analyzer/lib/src/task/strong/ast_properties.dart View 1 chunk +49 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 18 chunks +170 lines, -61 lines 0 comments Download
D pkg/analyzer/lib/src/task/strong/info.dart View 1 chunk +0 lines, -468 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 54 chunks +155 lines, -156 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 41 chunks +87 lines, -87 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 12 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Jennifer Messerly
Committed patchset #1 (id:1) manually as 3e45751a7bdd7c17840f614015c8eb2633667fd6 (presubmit successful).
4 years, 6 months ago (2016-06-13 17:50:02 UTC) #4
Jennifer Messerly
4 years, 6 months ago (2016-06-13 17:50:20 UTC) #5
Leaf
4 years, 6 months ago (2016-06-13 18:31:18 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698