Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: src/messages.cc

Issue 2062793002: Revert of [wasm] Refactor function name table and lookup (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/wasm/wasm-function-name-table.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.cc
diff --git a/src/messages.cc b/src/messages.cc
index ee364b9bc6496d786c93eaf747b163476fa6a922..86d0277f2afcc4bc7b2751399b31805c5eeaf252 100644
--- a/src/messages.cc
+++ b/src/messages.cc
@@ -205,8 +205,10 @@
Handle<Object> CallSite::GetFunctionName() {
if (IsWasm()) {
- return wasm::GetWasmFunctionNameOrNull(isolate_, wasm_obj_,
- wasm_func_index_);
+ MaybeHandle<String> name =
+ wasm::GetWasmFunctionName(wasm_obj_, wasm_func_index_);
+ if (name.is_null()) return isolate_->factory()->null_value();
+ return name.ToHandleChecked();
}
Handle<String> result = JSFunction::GetName(fun_);
if (result->length() != 0) return result;
« no previous file with comments | « src/isolate.cc ('k') | src/wasm/wasm-function-name-table.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698