Restrict 'disable_post_sub_buffers_for_onscreen_surfaces' workaround to glx/gl

Restrict 'disable_post_sub_buffers_for_onscreen_surfaces' workaround to glx/gl

Currently it is applied for all Mesa drivers. Since the problem comes
from glXCopySubBufferMESA we do not need the workaround with egl/gles.

BUG=619514
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8d8650011ea42e383dc4d4173c9301907e616bf9
Cr-Commit-Position: refs/heads/master@{#400276}

[Julien Isorce Samsung, 2016-06-13 09:52:30]

Description was changed from

==========
Restrict 'disable_post_sub_buffers_for_onscreen_surfaces' workaround on egl/gles

Currently it is applied for all Mesa drivers. Since the problem comes
from glXCopySubBufferMESA we do not need the workaround with egl/gles.

BUG=619514

R=piman@chromium.org
==========

to

==========
Restrict 'disable_post_sub_buffers_for_onscreen_surfaces' workaround on egl/gles

Currently it is applied for all Mesa drivers. Since the problem comes
from glXCopySubBufferMESA we do not need the workaround with egl/gles.

BUG=619514

R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Julien Isorce Samsung, 2016-06-13 09:52:45]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 09:52:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062763002/1

[Julien Isorce Samsung, 2016-06-13 09:54:10]

Description was changed from

==========
Restrict 'disable_post_sub_buffers_for_onscreen_surfaces' workaround on egl/gles

Currently it is applied for all Mesa drivers. Since the problem comes
from glXCopySubBufferMESA we do not need the workaround with egl/gles.

BUG=619514

R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Restrict 'disable_post_sub_buffers_for_onscreen_surfaces' workaround to glx/gl

Currently it is applied for all Mesa drivers. Since the problem comes
from glXCopySubBufferMESA we do not need the workaround with egl/gles.

BUG=619514

R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-13 12:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 12:05:52]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Julien Isorce Samsung, 2016-06-13 14:59:43]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 15:00:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062763002/20001

[commit-bot: I haz the power, 2016-06-13 16:49:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 16:49:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Julien Isorce Samsung, 2016-06-14 11:07:00]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 11:07:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062763002/60001

[commit-bot: I haz the power, 2016-06-14 14:35:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 14:35:51]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-06-14 15:43:43]

On 2016/06/14 14:35:51, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

I did quite a lot of testing and I have not find any regression so far. Though I
still need to try without a compositing manager as you suggested in comment 39
of http://crbug.com/339493.

[piman, 2016-06-14 16:55:17]

lgtm

[Julien Isorce Samsung, 2016-06-15 13:48:31]

On 2016/06/14 15:43:43, Julien Isorce wrote:
> On 2016/06/14 14:35:51, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> I did quite a lot of testing and I have not find any regression so far. Though
I
> still need to try without a compositing manager as you suggested in comment 39
> of http://crbug.com/339493.

Today I did tests without compositing manager so by forcing --use-gl=egl and
reverting patch
that spawns xcompmgr with xvfb. I ran content_unittests and some browser_tests
and I have
not found any regression.

On 2016/06/14 16:55:17, piman wrote:
> lgtm

So I'll submit the CL. Thx

[Julien Isorce Samsung, 2016-06-15 13:48:42]

The CQ bit was checked by j.isorce@samsung.com

[commit-bot: I haz the power, 2016-06-15 13:49:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062763002/60001

[commit-bot: I haz the power, 2016-06-15 15:01:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 15:01:14]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Julien Isorce Samsung, 2016-06-15 21:54:59]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-15 21:55:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062763002/80001

[commit-bot: I haz the power, 2016-06-16 00:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 00:30:11]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Julien Isorce Samsung, 2016-06-16 20:18:06]

The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 20:18:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062763002/100001

[commit-bot: I haz the power, 2016-06-16 21:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 21:55:54]

Dry run: This issue passed the CQ dry run.

[Julien Isorce Samsung, 2016-06-16 21:57:04]

The CQ bit was checked by j.isorce@samsung.com

[Julien Isorce Samsung, 2016-06-16 21:57:05]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2062763002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-16 21:58:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062763002/100001

[commit-bot: I haz the power, 2016-06-16 22:04:52]

Description was changed from

==========
Restrict 'disable_post_sub_buffers_for_onscreen_surfaces' workaround to glx/gl

Currently it is applied for all Mesa drivers. Since the problem comes
from glXCopySubBufferMESA we do not need the workaround with egl/gles.

BUG=619514

R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Restrict 'disable_post_sub_buffers_for_onscreen_surfaces' workaround to glx/gl

Currently it is applied for all Mesa drivers. Since the problem comes
from glXCopySubBufferMESA we do not need the workaround with egl/gles.

BUG=619514

R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-16 22:04:53]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-16 22:07:33]

Description was changed from

==========
Restrict 'disable_post_sub_buffers_for_onscreen_surfaces' workaround to glx/gl

Currently it is applied for all Mesa drivers. Since the problem comes
from glXCopySubBufferMESA we do not need the workaround with egl/gles.

BUG=619514

R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Restrict 'disable_post_sub_buffers_for_onscreen_surfaces' workaround to glx/gl

Currently it is applied for all Mesa drivers. Since the problem comes
from glXCopySubBufferMESA we do not need the workaround with egl/gles.

BUG=619514

R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/8d8650011ea42e383dc4d4173c9301907e616bf9
Cr-Commit-Position: refs/heads/master@{#400276}
==========

[commit-bot: I haz the power, 2016-06-16 22:07:34]

Patchset 6 (id:??) landed as
https://crrev.com/8d8650011ea42e383dc4d4173c9301907e616bf9
Cr-Commit-Position: refs/heads/master@{#400276}