Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc

Issue 2062743002: Randomly enable leak detector based on probability parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use RenderThreadObserver interface to shutdown remote client on same thread Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc
diff --git a/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc b/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc
index 45e2b5e872199b78fc69a052b924b393761ddc61..e02182bbf995c50ca1eee93e7301fb8738b7552f 100644
--- a/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc
+++ b/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc
@@ -32,7 +32,10 @@ void LeakDetectorRemoteController::GetParams(
// should not initialize anything if the params are empty.
MemoryLeakReportProto_Params params;
if (g_local_controller) {
- params = g_local_controller->GetParams();
+ params = g_local_controller->GetParamsAndRecordRequest();
+ // A non-zero sampling rate tells the remote process to enable the leak
+ // detector. Otherwise, the remote process will not initialize it.
+ leak_detector_enabled_on_remote_process_ = params.sampling_rate() > 0;
}
mojo::StructPtr<mojom::LeakDetectorParams> mojo_params =
@@ -58,9 +61,21 @@ void LeakDetectorRemoteController::SendLeakReports(
g_local_controller->SendLeakReports(report_protos);
}
+void LeakDetectorRemoteController::OnRemoteProcessShutdown() {
+ if (leak_detector_enabled_on_remote_process_) {
+ DCHECK(g_local_controller);
+ g_local_controller->OnRemoteProcessShutdown();
+ }
+}
+
LeakDetectorRemoteController::LeakDetectorRemoteController(
mojom::LeakDetectorRequest request)
- : binding_(this, std::move(request)) {}
+ : binding_(this, std::move(request)),
+ leak_detector_enabled_on_remote_process_(false) {
+ binding_.set_connection_error_handler(
+ base::Bind(&LeakDetectorRemoteController::OnRemoteProcessShutdown,
+ base::Unretained(this)));
+}
// static
void LeakDetectorRemoteController::SetLocalControllerInstance(

Powered by Google App Engine
This is Rietveld 408576698