Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2062713002: MIPS64: Fix compilation issues on MIPS64R6 with Clang. (Closed)

Created:
4 years, 6 months ago by Ilija.Pavlovic1
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix compilation issues on MIPS64R6 with Clang. This patch enables V8 build with Clang without errors for MIPS64 release R6. TEST= BUG= Committed: https://crrev.com/3dbc7586fb6d6daa878015a83524dd8c52bbc2c9 Cr-Commit-Position: refs/heads/master@{#36948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M src/base/atomicops_internals_mips64_gcc.h View 2 chunks +26 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ilija.Pavlovic1
PTAL. @jochen: Your "lgtm" is required here so I would ask you to check this ...
4 years, 6 months ago (2016-06-13 09:24:07 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-13 15:20:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062713002/1
4 years, 6 months ago (2016-06-14 06:11:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 07:01:54 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 07:02:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dbc7586fb6d6daa878015a83524dd8c52bbc2c9
Cr-Commit-Position: refs/heads/master@{#36948}

Powered by Google App Engine
This is Rietveld 408576698