Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1538)

Issue 2062673002: Convert unsupported* and video-append* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert unsupported* and video-append* tests to testharness.js Cleaning up unsupported* and video-append* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/f0b4140302ed4571ec1c063fcb0a87b7cca67514 Cr-Commit-Position: refs/heads/master@{#399392}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -59 lines) Patch
M third_party/WebKit/LayoutTests/media/unsupported-rtsp.html View 1 chunk +12 lines, -14 lines 1 comment Download
D third_party/WebKit/LayoutTests/media/unsupported-rtsp-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/unsupported-tracks.html View 1 chunk +11 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/unsupported-tracks-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-append-source.html View 1 chunk +16 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-append-source-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-12 12:43:06 UTC) #5
fs
lgtm https://codereview.chromium.org/2062673002/diff/40001/third_party/WebKit/LayoutTests/media/unsupported-rtsp.html File third_party/WebKit/LayoutTests/media/unsupported-rtsp.html (right): https://codereview.chromium.org/2062673002/diff/40001/third_party/WebKit/LayoutTests/media/unsupported-rtsp.html#newcode9 third_party/WebKit/LayoutTests/media/unsupported-rtsp.html:9: video.src = "rtsp://a2047.v1411b.c1411.g.vq.akamaistream.net/5/2047/1411/2_h264_650/1a1a1ae454c430950065de4cbb2f94c226950c7ae655b61a48a91475e243acda3dac194879adde0f/wwdc_2006_2_650.mov"; This is... interesting. I guess ...
4 years, 6 months ago (2016-06-12 14:04:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062673002/40001
4 years, 6 months ago (2016-06-12 14:17:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 6 months ago (2016-06-12 17:03:46 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-12 17:05:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0b4140302ed4571ec1c063fcb0a87b7cca67514
Cr-Commit-Position: refs/heads/master@{#399392}

Powered by Google App Engine
This is Rietveld 408576698