Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2062613002: Add TrimmedAppID to info service. (Closed)

Created:
4 years, 6 months ago by iannucci
Modified:
4 years, 6 months ago
Reviewers:
dnj, dnj (Google)
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add TrimmedAppID to info service. Also refactor info service to share common 'augmented' methods in the service/info package itself, ala service/datastore. Split out from CL: https://chromiumcodereview.appspot.com/1537883002 R=dnj@chromium.org BUG=550684 Committed: https://github.com/luci/gae/commit/48d5fbded2f1bc5cfa24d377c180d871a238351e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -73 lines) Patch
M filter/count/gi.go View 4 chunks +3 lines, -9 lines 0 comments Download
M filter/featureBreaker/gi.go View 6 chunks +8 lines, -16 lines 0 comments Download
M impl/dummy/dummy.go View 3 chunks +2 lines, -4 lines 0 comments Download
M impl/memory/info.go View 2 chunks +3 lines, -11 lines 0 comments Download
M impl/memory/info_test.go View 1 chunk +0 lines, -12 lines 0 comments Download
M impl/prod/info.go View 2 chunks +1 line, -8 lines 0 comments Download
M service/info/context.go View 3 chunks +10 lines, -10 lines 0 comments Download
M service/info/interface.go View 3 chunks +21 lines, -3 lines 0 comments Download
A service/info/wrapper.go View 1 chunk +30 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
iannucci
4 years, 6 months ago (2016-06-11 02:15:58 UTC) #1
dnj (Google)
lgtm w/ comment https://codereview.chromium.org/2062613002/diff/1/service/info/wrapper.go File service/info/wrapper.go (right): https://codereview.chromium.org/2062613002/diff/1/service/info/wrapper.go#newcode19 service/info/wrapper.go:19: func (i infoImpl) MustNamespace(namespace string) context.Context ...
4 years, 6 months ago (2016-06-11 02:47:39 UTC) #3
iannucci
https://chromiumcodereview.appspot.com/2062613002/diff/1/service/info/wrapper.go File service/info/wrapper.go (right): https://chromiumcodereview.appspot.com/2062613002/diff/1/service/info/wrapper.go#newcode19 service/info/wrapper.go:19: func (i infoImpl) MustNamespace(namespace string) context.Context { On 2016/06/11 ...
4 years, 6 months ago (2016-06-14 00:01:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062613002/1
4 years, 6 months ago (2016-06-14 00:01:29 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 00:07:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/48d5fbded2f1bc5cfa24d377c180d871a238351e

Powered by Google App Engine
This is Rietveld 408576698