Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 2062583002: Add totalAmount to PaymentResponse. (Closed)

Created:
4 years, 6 months ago by please use gerrit instead
Modified:
4 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, dglazkov+blink, blink-reviews, darin (slow to review), ben+mojo_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add totalAmount to PaymentResponse. This patch adds the totalAmount to PaymentResponse. This reflects the total amount that the user has confirmed they will pay. The change that introduced totalAmount also introduced PaymentMethodModifier, which is not in this patch. https://w3c.github.io/browser-payment-api/#paymentresponse-interface https://github.com/w3c/browser-payment-api/commit/67f4f25f4a0562e7b13c5139e1bb8f8b1d41f53a BUG=618860 Committed: https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8 Cr-Commit-Position: refs/heads/master@{#399644}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -29 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/android/payments/dynamic_shipping.js View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/test/data/android/payments/free_shipping.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/android/payments/no_shipping.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.h View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.cpp View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp View 1 2 5 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/payments/payment_request.mojom View 1 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 30 (14 generated)
please use gerrit instead
(mek@ is ooo ? haraken@ : mek@), ptal WebKit. cpalmer@, ptal payment_request.mojom. dfalcantara@, ptal Java.
4 years, 6 months ago (2016-06-11 00:43:56 UTC) #3
please use gerrit instead
-cpalmer@ +palmer@
4 years, 6 months ago (2016-06-11 00:44:41 UTC) #5
palmer
lgtm
4 years, 6 months ago (2016-06-11 01:01:17 UTC) #6
haraken
WebKit LGTM (but I can just review in terms of implementation.)
4 years, 6 months ago (2016-06-11 05:26:49 UTC) #7
please use gerrit instead
On 2016/06/11 05:26:49, haraken wrote: > (but I can just review in terms of implementation.) ...
4 years, 6 months ago (2016-06-11 16:37:43 UTC) #8
gone
java lgtm
4 years, 6 months ago (2016-06-13 16:43:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062583002/20001
4 years, 6 months ago (2016-06-13 16:56:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/238034)
4 years, 6 months ago (2016-06-13 20:17:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062583002/20001
4 years, 6 months ago (2016-06-13 20:42:16 UTC) #15
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/public/platform/modules/payments/payment_request.mojom: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-13 22:45:22 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 22:45:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062583002/40001
4 years, 6 months ago (2016-06-13 22:52:45 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/152369) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-13 23:05:26 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062583002/60001
4 years, 6 months ago (2016-06-14 01:03:40 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-14 02:35:36 UTC) #28
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 03:40:22 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/65f870288f6c830606d8eb9b0510cd0f156724b8
Cr-Commit-Position: refs/heads/master@{#399644}

Powered by Google App Engine
This is Rietveld 408576698