Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
206253006:
Add ChromiumAATTest for testing AAT font support in the shaper (Closed)
|
Created:
6 years, 9 months ago by Dominik Röttsches Modified:
6 years, 9 months ago CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@harfbuzzCompileCoretext Visibility:
Public. |
DescriptionAdd ChromiumAATTest for testing AAT font support in the shaper
TBR=avi@chromium.org
BUG=354497
TEST=NONE
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258429
Patch Set 1 #
Messages
Total messages: 29 (0 generated)
Emil, I am not sure, I touched the correct files now, but with these modifications, the test works in content_shell / run-webkit-tests.
On 2014/03/20 17:18:39, Dominik Röttsches wrote: > Emil, I am not sure, I touched the correct files now, but with these > modifications, the test works in content_shell / run-webkit-tests. Great, that's all that really matters! LGTM
The CQ bit was checked by eae@chromium.org
The CQ bit was unchecked by eae@chromium.org
On 2014/03/20 17:19:44, eae wrote: > The CQ bit was unchecked by mailto:eae@chromium.org You'll need a content OWNER to review this as well.
On 2014/03/20 17:20:30, eae wrote: > On 2014/03/20 17:19:44, eae wrote: > > The CQ bit was unchecked by mailto:eae@chromium.org > > You'll need a content OWNER to review this as well. LGTM, too. In this case, TBR might be ok, but it's your call.
The CQ bit was checked by eae@chromium.org
On 2014/03/20 17:39:58, Jungshik Shin wrote: > On 2014/03/20 17:20:30, eae wrote: > > On 2014/03/20 17:19:44, eae wrote: > > > The CQ bit was unchecked by mailto:eae@chromium.org > > > > You'll need a content OWNER to review this as well. > > LGTM, too. In this case, TBR might be ok, but it's your call. Thanks Jungshik!
The CQ bit was unchecked by dominik.rottsches@intel.com
Unchecking cq bit for a moment, some reproducibility issue here that I'm checking.
The CQ bit was checked by dominik.rottsches@intel.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/206253006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
The CQ bit was checked by dominik.rottsches@intel.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/206253006/1
The CQ bit was unchecked by jshin@chromium.org
The CQ bit was checked by jshin@chromium.org
On 2014/03/20 18:39:17, Jungshik Shin wrote: > The CQ bit was unchecked by https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=jshin@chromium.org I added TBR=sky@chromium.org and checked CQ bit again to make CQ happy.
On 2014/03/20 18:40:18, Jungshik Shin wrote: > On 2014/03/20 18:39:17, Jungshik Shin wrote: > > The CQ bit was unchecked by > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=jshin%40chromium.org > > I added https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=TBR=sky@chromium.org and checked CQ bit again to make CQ happy. oops. avi@ is better.
The CQ bit was unchecked by jshin@chromium.org
The CQ bit was checked by jshin@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by dominik.rottsches@intel.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/206253006/1
lgtm
Message was sent while issue was closed.
Change committed as 258429 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
