Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 206253005: DevTools: Get rid of WebInspector.ConsoleModel.UIDelegate (Closed)

Created:
6 years, 9 months ago by sergeyv
Modified:
6 years, 9 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: Get rid of WebInspector.ConsoleModel.UIDelegate BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169667

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address vsevik's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -68 lines) Patch
M LayoutTests/http/tests/inspector/command-line-api-inspect.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-command-line-api.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ConsoleModel.js View 1 6 chunks +8 lines, -40 lines 0 comments Download
M Source/devtools/front_end/ConsolePanel.js View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ConsoleView.js View 1 4 chunks +10 lines, -22 lines 0 comments Download
M Source/devtools/front_end/JavaScriptSourceFrame.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 27 (0 generated)
sergeyv
6 years, 9 months ago (2014-03-20 13:10:19 UTC) #1
vsevik
https://codereview.chromium.org/206253005/diff/1/Source/devtools/front_end/ConsoleModel.js File Source/devtools/front_end/ConsoleModel.js (right): https://codereview.chromium.org/206253005/diff/1/Source/devtools/front_end/ConsoleModel.js#newcode52 Source/devtools/front_end/ConsoleModel.js:52: EvaluationResultMessageAdded: "evaluation-result-message-added", Let's name it CommandEvaluated and include original ...
6 years, 9 months ago (2014-03-20 13:22:45 UTC) #2
sergeyv
https://codereview.chromium.org/206253005/diff/1/Source/devtools/front_end/ConsoleModel.js File Source/devtools/front_end/ConsoleModel.js (right): https://codereview.chromium.org/206253005/diff/1/Source/devtools/front_end/ConsoleModel.js#newcode52 Source/devtools/front_end/ConsoleModel.js:52: EvaluationResultMessageAdded: "evaluation-result-message-added", On 2014/03/20 13:22:46, vsevik wrote: > Let's ...
6 years, 9 months ago (2014-03-20 13:34:02 UTC) #3
vsevik
lgtm
6 years, 9 months ago (2014-03-20 13:39:26 UTC) #4
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-20 13:39:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206253005/20001
6 years, 9 months ago (2014-03-20 13:39:53 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 13:41:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-20 13:41:05 UTC) #8
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-20 13:42:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206253005/20001
6 years, 9 months ago (2014-03-20 13:42:43 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 14:16:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-20 14:16:25 UTC) #12
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-20 14:17:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206253005/20001
6 years, 9 months ago (2014-03-20 14:17:22 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 14:45:22 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 14:45:22 UTC) #16
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-20 14:45:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206253005/20001
6 years, 9 months ago (2014-03-20 14:45:40 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 15:47:15 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 15:47:16 UTC) #20
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-20 15:48:28 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206253005/20001
6 years, 9 months ago (2014-03-20 15:48:33 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 15:51:27 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 15:51:28 UTC) #24
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 9 months ago (2014-03-20 15:53:35 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/206253005/20001
6 years, 9 months ago (2014-03-20 15:53:54 UTC) #26
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 16:58:05 UTC) #27
Message was sent while issue was closed. 
Change committed as 169667

Powered by Google App Engine
This is Rietveld 408576698