Settings People Revamp: Add 'Manage Supervised Users' row

Settings People Revamp: Add 'Manage Supervised Users' row

Only displays when user actually has supervised users.

BUG=617245, 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0
Cr-Commit-Position: refs/heads/master@{#399341}

[tommycli, 2016-06-10 22:09:47]

Description was changed from

==========
Settings People Revamp: Add 'Manage Supervised Users' row

Only displays when user actually has supervised users.

BUG=617245, 563721
==========

to

==========
Settings People Revamp: Add 'Manage Supervised Users' row

Only displays when user actually has supervised users.

BUG=617245, 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-06-10 22:11:38]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 22:12:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062503002/1

[tommycli, 2016-06-10 22:15:32]

tommycli@chromium.org changed reviewers:
+ hcarmona@chromium.org

[tommycli, 2016-06-10 22:15:33]

hcarmona: PTAL, thanks!

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/profile_info_handler.cc (right):

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/profile_info_handler.cc:188: return
!profile_->GetPrefs()->GetDictionary(prefs::kSupervisedUsers)->empty();
This logic copied from
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/options/browser_...

[hcarmona, 2016-06-10 22:58:08]

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/people_page.js:54: value: false,
Is the default necessary? This is always set on attached.

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/profile_info_handler.cc (right):

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/profile_info_handler.cc:188: return
!profile_->GetPrefs()->GetDictionary(prefs::kSupervisedUsers)->empty();
On 2016/06/10 22:15:32, tommycli wrote:
> This logic copied from
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/options/browser_...

Acknowledged.

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc (right):

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc:175:
EXPECT_FALSE(has_supervised_users);
Is it possible to add a test where |has_supervised_users| is expected to be
true?

[tommycli, 2016-06-10 23:28:45]

hcarmona: Thanks for the fast review!

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/people_page.js:54: value: false,
On 2016/06/10 22:58:08, Hector Carmona wrote:
> Is the default necessary? This is always set on attached.

Done.

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc (right):

https://codereview.chromium.org/2062503002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc:175:
EXPECT_FALSE(has_supervised_users);
On 2016/06/10 22:58:08, Hector Carmona wrote:
> Is it possible to add a test where |has_supervised_users| is expected to be
> true?

Done. Yes, I was able to enhance the test using this feedback.

[hcarmona, 2016-06-10 23:30:49]

lgtm

[tommycli, 2016-06-10 23:31:00]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-06-10 23:32:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062503002/60001

[commit-bot: I haz the power, 2016-06-11 01:02:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-11 01:03:11]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-11 01:04:19]

Description was changed from

==========
Settings People Revamp: Add 'Manage Supervised Users' row

Only displays when user actually has supervised users.

BUG=617245, 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings People Revamp: Add 'Manage Supervised Users' row

Only displays when user actually has supervised users.

BUG=617245, 563721
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0
Cr-Commit-Position: refs/heads/master@{#399341}
==========

[commit-bot: I haz the power, 2016-06-11 01:04:20]

Patchset 4 (id:??) landed as
https://crrev.com/4dac5631a4c6eaf4a6466972db9e609ac61347c0
Cr-Commit-Position: refs/heads/master@{#399341}