Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2062433002: Revert of Change //build/config/compiler:optimize_max to use -O3. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jochen (gone - plz use gerrit), Michael Hablich, kcc1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change //build/config/compiler:optimize_max to use -O3. (patchset #1 id:1 of https://codereview.chromium.org/2048163002/ ) Reason for revert: Reverting, this caused a size regression for cronet that is more important to them than any likely perf gains. I'll re-land a different CL that's less broad. Original issue's description: > Change //build/config/compiler:optimize_max to use -O3. > > Certain components (e.g., v8) really want to be compiled with -O3, > but the current ":optimize_max" setting just used -O2. Since "max" > should theoretically mean "max", let's try making it be -O3 across > the board and see what happens. > > R=brettw@chromium.org > BUG=616031 > > Committed: https://crrev.com/96a6dfa2c30ab9b22abd20c87ed0e0d6ae41c40e > Cr-Commit-Position: refs/heads/master@{#398704} TBR=brettw@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=616031 Committed: https://crrev.com/c4dc398543c8a7cbd4b5f8bfe3495d6182dc3f19 Cr-Commit-Position: refs/heads/master@{#399276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
Created Revert of Change //build/config/compiler:optimize_max to use -O3.
4 years, 6 months ago (2016-06-10 20:00:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062433002/1
4 years, 6 months ago (2016-06-10 20:00:57 UTC) #3
brettw
lgtm
4 years, 6 months ago (2016-06-10 20:59:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 21:41:33 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 21:41:50 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 21:43:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4dc398543c8a7cbd4b5f8bfe3495d6182dc3f19
Cr-Commit-Position: refs/heads/master@{#399276}

Powered by Google App Engine
This is Rietveld 408576698