Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 206243002: Check if ArrayBuffer allocation in ArrayBufferBuilder is successful. (Closed)

Created:
6 years, 9 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, tzik, nhiroki, abarth-chromium, kinuko, Inactive, Mikhail, adamk+blink_chromium.org
Visibility:
Public.

Description

Check if ArrayBuffer allocation in ArrayBufferBuilder is successful. ArrayBuffer::create may return NULL if allocation fails. BUG=353966 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +8 lines, -6 lines 0 comments Download
M Source/wtf/ArrayBufferBuilder.h View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 9 months ago (2014-03-20 09:52:11 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-20 16:47:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/206243002/1
6 years, 9 months ago (2014-03-20 16:47:40 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 16:50:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-20 16:50:11 UTC) #5
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-20 18:42:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/206243002/1
6 years, 9 months ago (2014-03-20 18:42:12 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 19:31:06 UTC) #8
Message was sent while issue was closed. 
Change committed as 169680

Powered by Google App Engine
This is Rietveld 408576698