Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2062363002: [gn] Fix config for icu data file and swarming (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix config for icu data file and swarming Fix after: https://codereview.chromium.org/2042253002/ https://codereview.chromium.org/2049743002/ Using the data file is the default now and it shouldn't be overridden in v8's build_overrides. Also the isolate logic now needs to include the gni file specifying the flag. BUG=chromium:616033 TBR=jochen@chromium.org, vogelheim@chromium.org NOTRY=true Committed: https://crrev.com/a774fa5142ae9d8d3539e1f25f6e9f04893a2121 Cr-Commit-Position: refs/heads/master@{#36998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build_overrides/v8.gni View 1 chunk +0 lines, -1 line 0 comments Download
M gni/isolate.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Achenbach
TBR
4 years, 6 months ago (2016-06-15 11:23:14 UTC) #3
vogelheim
lgtm
4 years, 6 months ago (2016-06-15 11:30:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062363002/1
4 years, 6 months ago (2016-06-15 11:53:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 11:57:18 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 11:57:21 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 12:00:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a774fa5142ae9d8d3539e1f25f6e9f04893a2121
Cr-Commit-Position: refs/heads/master@{#36998}

Powered by Google App Engine
This is Rietveld 408576698