Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3285)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2062353002: Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and force opaque for color_ntp_background from the theme machinery Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 5339809471f2b05aeb33fb80c0354ed45c98710c..a84243f05541faf3aeffab9b5bc88827b829a0da 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -224,11 +224,9 @@ void PaintDetachedBookmarkBar(gfx::Canvas* canvas,
// The detached background color may be partially transparent, but the layer
// for |view| must be painted opaquely to avoid subpixel anti-aliasing
// artifacts, so we recreate the contents container base color here.
Peter Kasting 2016/07/11 01:41:58 The detached background color no longer exists, an
Julien Isorce Samsung 2016/07/13 15:01:33 Done.
- canvas->FillRect(fill_rect,
- tp->GetColor(ThemeProperties::COLOR_CONTROL_BACKGROUND));
canvas->FillRect(
fill_rect,
- tp->GetColor(ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND));
+ tp->GetColor(ThemeProperties::COLOR_NTP_BACKGROUND));
// Draw the separators above and below bookmark bar;
// if animating, these are fading in/out.
@@ -2069,7 +2067,7 @@ void BrowserView::InitViews() {
contents_container_ = new views::View();
contents_container_->set_background(views::Background::CreateSolidBackground(
- GetThemeProvider()->GetColor(ThemeProperties::COLOR_CONTROL_BACKGROUND)));
+ GetThemeProvider()->GetColor(ThemeProperties::COLOR_NTP_BACKGROUND)));
contents_container_->AddChildView(devtools_web_view_);
contents_container_->AddChildView(contents_web_view_);
contents_container_->SetLayoutManager(new ContentsLayoutManager(

Powered by Google App Engine
This is Rietveld 408576698