Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND

chrome/browser/ui/views/frame/browser_view.cc

Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 2e51b4b4eb9ce31cf8b059d69fb9978a89e97d8e..7ee8bfcbf33d87143545bc3841dd2ef8d4fd4cbb 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -224,11 +224,9 @@ void PaintDetachedBookmarkBar(gfx::Canvas* canvas,
   // The detached background color may be partially transparent, but the layer
   // for |view| must be painted opaquely to avoid subpixel anti-aliasing
   // artifacts, so we recreate the contents container base color here.
-  canvas->FillRect(fill_rect,
-                   tp->GetColor(ThemeProperties::COLOR_CONTROL_BACKGROUND));
   canvas->FillRect(
       fill_rect,
-      tp->GetColor(ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND));
+      tp->GetColor(ThemeProperties::COLOR_NTP_BACKGROUND) | 0xFF000000);

[Peter Kasting, 2016/07/01 01:10:02]

Use SkColorSetA() instead of direct bit manipulation.

But maybe we should force this color to opaque down in the theme code?  Do we
ever want to allow a transparent color for COLOR_NTP_BACKGROUND?  What sorts of
effects do we get today with a partly-transparent NTP background color?

[Julien Isorce Samsung, 2016/07/01 13:27:45]

Done thx!
I added 2 new screenshots in the bug. One that does not force opaque in that
place. (in browser_view.cc), and second screenshot that shows result with this
CL.

I think we should keep the force opaque just here, not down in the theme because
I think alpha channel should be customizable too.

 
   // Draw the separators above and below bookmark bar;
   // if animating, these are fading in/out.
@@ -2069,7 +2067,7 @@ void BrowserView::InitViews() {
 
   contents_container_ = new views::View();
   contents_container_->set_background(views::Background::CreateSolidBackground(
-      GetThemeProvider()->GetColor(ThemeProperties::COLOR_CONTROL_BACKGROUND)));
+      GetThemeProvider()->GetColor(ThemeProperties::COLOR_NTP_BACKGROUND)));
   contents_container_->AddChildView(devtools_web_view_);
   contents_container_->AddChildView(contents_web_view_);
   contents_container_->SetLayoutManager(new ContentsLayoutManager(