Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: chrome/browser/themes/theme_properties.cc

Issue 2062353002: Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More clang build fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/themes/theme_properties.h" 5 #include "chrome/browser/themes/theme_properties.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 const SkColor kDefaultColorToolbar[] = {SkColorSetRGB(0xE6, 0xE6, 0xE6), 60 const SkColor kDefaultColorToolbar[] = {SkColorSetRGB(0xE6, 0xE6, 0xE6),
61 SkColorSetRGB(0xF2, 0xF2, 0xF2)}; 61 SkColorSetRGB(0xF2, 0xF2, 0xF2)};
62 const SkColor kDefaultColorToolbarIncognito[] = { 62 const SkColor kDefaultColorToolbarIncognito[] = {
63 SkColorSetRGB(0xE6, 0xE6, 0xE6), SkColorSetRGB(0x50, 0x50, 0x50)}; 63 SkColorSetRGB(0xE6, 0xE6, 0xE6), SkColorSetRGB(0x50, 0x50, 0x50)};
64 #else 64 #else
65 const SkColor kDefaultColorToolbar[] = {SkColorSetRGB(0xDF, 0xDF, 0xDF), 65 const SkColor kDefaultColorToolbar[] = {SkColorSetRGB(0xDF, 0xDF, 0xDF),
66 SkColorSetRGB(0xF2, 0xF2, 0xF2)}; 66 SkColorSetRGB(0xF2, 0xF2, 0xF2)};
67 const SkColor kDefaultColorToolbarIncognito[] = { 67 const SkColor kDefaultColorToolbarIncognito[] = {
68 SkColorSetRGB(0xDF, 0xDF, 0xDF), SkColorSetRGB(0x50, 0x50, 0x50)}; 68 SkColorSetRGB(0xDF, 0xDF, 0xDF), SkColorSetRGB(0x50, 0x50, 0x50)};
69 #endif // OS_MACOSX 69 #endif // OS_MACOSX
70 const SkColor kDefaultDetachedBookmarkBarBackground[] = {
71 SkColorSetRGB(0xF1, 0xF1, 0xF1), SK_ColorWHITE};
72 const SkColor kDefaultDetachedBookmarkBarBackgroundIncognito[] = {
73 SkColorSetRGB(0xF1, 0xF1, 0xF1), SkColorSetRGB(0x32, 0x32, 0x32)};
74
75 constexpr SkColor kDefaultColorTabText = SK_ColorBLACK; 70 constexpr SkColor kDefaultColorTabText = SK_ColorBLACK;
76 constexpr SkColor kDefaultColorTabTextIncognito[] = {kDefaultColorTabText, 71 constexpr SkColor kDefaultColorTabTextIncognito[] = {kDefaultColorTabText,
77 SK_ColorWHITE}; 72 SK_ColorWHITE};
78 73
79 #if defined(OS_MACOSX) 74 #if defined(OS_MACOSX)
80 constexpr SkColor kDefaultColorBackgroundTabText[] = {SK_ColorBLACK, 75 constexpr SkColor kDefaultColorBackgroundTabText[] = {SK_ColorBLACK,
81 SK_ColorBLACK}; 76 SK_ColorBLACK};
82 constexpr SkColor kDefaultColorBackgroundTabTextIncognito[] = { 77 constexpr SkColor kDefaultColorBackgroundTabTextIncognito[] = {
83 kDefaultColorBackgroundTabText[0], SK_ColorWHITE}; 78 kDefaultColorBackgroundTabText[0], SK_ColorWHITE};
84 #else 79 #else
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 kDefaultTintButtons, {-1, -1, 0.85}}; 112 kDefaultTintButtons, {-1, -1, 0.85}};
118 constexpr color_utils::HSL kDefaultTintFrame = {-1, -1, -1}; 113 constexpr color_utils::HSL kDefaultTintFrame = {-1, -1, -1};
119 constexpr color_utils::HSL kDefaultTintFrameInactive = {-1, -1, 0.75}; 114 constexpr color_utils::HSL kDefaultTintFrameInactive = {-1, -1, 0.75};
120 constexpr color_utils::HSL kDefaultTintFrameIncognito = {-1, 0.2, 0.35}; 115 constexpr color_utils::HSL kDefaultTintFrameIncognito = {-1, 0.2, 0.35};
121 constexpr color_utils::HSL kDefaultTintFrameIncognitoInactive = {-1, 0.3, 0.6}; 116 constexpr color_utils::HSL kDefaultTintFrameIncognitoInactive = {-1, 0.3, 0.6};
122 constexpr color_utils::HSL kDefaultTintBackgroundTab = {-1, -1, 0.75}; 117 constexpr color_utils::HSL kDefaultTintBackgroundTab = {-1, -1, 0.75};
123 118
124 // ---------------------------------------------------------------------------- 119 // ----------------------------------------------------------------------------
125 // Defaults for properties which are not stored in the browser theme pack. 120 // Defaults for properties which are not stored in the browser theme pack.
126 121
127 constexpr SkColor kDefaultColorControlBackground = SK_ColorWHITE;
128 const SkColor kDefaultDetachedBookmarkBarSeparator[] = { 122 const SkColor kDefaultDetachedBookmarkBarSeparator[] = {
129 SkColorSetRGB(0xAA, 0xAA, 0xAB), SkColorSetRGB(0xB6, 0xB4, 0xB6)}; 123 SkColorSetRGB(0xAA, 0xAA, 0xAB), SkColorSetRGB(0xB6, 0xB4, 0xB6)};
130 const SkColor kDefaultDetachedBookmarkBarSeparatorIncognito[] = { 124 const SkColor kDefaultDetachedBookmarkBarSeparatorIncognito[] = {
131 SkColorSetRGB(0xAA, 0xAA, 0xAB), SkColorSetRGB(0x28, 0x28, 0x28)}; 125 SkColorSetRGB(0xAA, 0xAA, 0xAB), SkColorSetRGB(0x28, 0x28, 0x28)};
132 const SkColor kDefaultToolbarTopSeparator = SkColorSetA(SK_ColorBLACK, 0x40); 126 const SkColor kDefaultToolbarTopSeparator = SkColorSetA(SK_ColorBLACK, 0x40);
133 127
134 #if defined(OS_MACOSX) 128 #if defined(OS_MACOSX)
135 const SkColor kDefaultColorFrameVibrancyOverlay[] = { 129 const SkColor kDefaultColorFrameVibrancyOverlay[] = {
136 SkColorSetA(SK_ColorBLACK, 0x19), SkColorSetARGB(0xE6, 0x14, 0x16, 0x18)}; 130 SkColorSetA(SK_ColorBLACK, 0x19), SkColorSetARGB(0xE6, 0x14, 0x16, 0x18)};
137 const SkColor kDefaultColorToolbarInactive[] = { 131 const SkColor kDefaultColorToolbarInactive[] = {
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 case COLOR_NTP_SECTION_TEXT: 343 case COLOR_NTP_SECTION_TEXT:
350 return kDefaultColorNTPSectionText; 344 return kDefaultColorNTPSectionText;
351 case COLOR_NTP_SECTION_LINK: 345 case COLOR_NTP_SECTION_LINK:
352 return kDefaultColorNTPSectionLink; 346 return kDefaultColorNTPSectionLink;
353 case COLOR_NTP_SECTION_LINK_UNDERLINE: 347 case COLOR_NTP_SECTION_LINK_UNDERLINE:
354 return TintForUnderline(kDefaultColorNTPSectionLink); 348 return TintForUnderline(kDefaultColorNTPSectionLink);
355 case COLOR_BUTTON_BACKGROUND: 349 case COLOR_BUTTON_BACKGROUND:
356 return kDefaultColorButtonBackground; 350 return kDefaultColorButtonBackground;
357 351
358 // Properties not stored in theme pack. 352 // Properties not stored in theme pack.
359 case COLOR_CONTROL_BACKGROUND:
360 return kDefaultColorControlBackground;
361 case COLOR_TOOLBAR_BOTTOM_SEPARATOR: 353 case COLOR_TOOLBAR_BOTTOM_SEPARATOR:
362 case COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR: 354 case COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR:
363 return otr ? kDefaultDetachedBookmarkBarSeparatorIncognito[mode] 355 return otr ? kDefaultDetachedBookmarkBarSeparatorIncognito[mode]
364 : kDefaultDetachedBookmarkBarSeparator[mode]; 356 : kDefaultDetachedBookmarkBarSeparator[mode];
365 case COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND:
366 return otr ? kDefaultDetachedBookmarkBarBackgroundIncognito[mode]
367 : kDefaultDetachedBookmarkBarBackground[mode];
368 case COLOR_TOOLBAR_TOP_SEPARATOR: 357 case COLOR_TOOLBAR_TOP_SEPARATOR:
369 case COLOR_TOOLBAR_TOP_SEPARATOR_INACTIVE: 358 case COLOR_TOOLBAR_TOP_SEPARATOR_INACTIVE:
370 return kDefaultToolbarTopSeparator; 359 return kDefaultToolbarTopSeparator;
371 #if defined(OS_MACOSX) 360 #if defined(OS_MACOSX)
372 case COLOR_FRAME_VIBRANCY_OVERLAY: 361 case COLOR_FRAME_VIBRANCY_OVERLAY:
373 return kDefaultColorFrameVibrancyOverlay[otr]; 362 return kDefaultColorFrameVibrancyOverlay[otr];
374 case COLOR_TOOLBAR_INACTIVE: 363 case COLOR_TOOLBAR_INACTIVE:
375 return otr ? kDefaultColorToolbarInactiveIncognito[mode] 364 return otr ? kDefaultColorToolbarInactiveIncognito[mode]
376 : kDefaultColorToolbarInactive[mode]; 365 : kDefaultColorToolbarInactive[mode];
377 case COLOR_BACKGROUND_TAB_INACTIVE: 366 case COLOR_BACKGROUND_TAB_INACTIVE:
(...skipping 17 matching lines...) Expand all
395 #endif 384 #endif
396 case COLOR_FRAME_INCOGNITO: 385 case COLOR_FRAME_INCOGNITO:
397 case COLOR_FRAME_INCOGNITO_INACTIVE: 386 case COLOR_FRAME_INCOGNITO_INACTIVE:
398 NOTREACHED() << "These values should be queried via their respective " 387 NOTREACHED() << "These values should be queried via their respective "
399 "non-incognito equivalents and an appropriate |otr| " 388 "non-incognito equivalents and an appropriate |otr| "
400 "value."; 389 "value.";
401 default: 390 default:
402 return gfx::kPlaceholderColor; 391 return gfx::kPlaceholderColor;
403 } 392 }
404 } 393 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698