Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

Issue 2062333002: mojo::Callback -> base::Callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc b/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
index 512423b419d9916192679317d2e869d02d202f1a..fd01a3f20e2b9cc7bf74033d4ef7929e9871faec 100644
--- a/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
@@ -20,26 +20,6 @@ namespace mojo {
namespace test {
namespace {
-template <typename Method, typename Class>
-class RunnableImpl {
- public:
- RunnableImpl(Method method, Class instance)
- : method_(method), instance_(instance) {}
- template <typename... Args>
- void Run(Args... args) const {
- (instance_->*method_)(args...);
- }
-
- private:
- Method method_;
- Class instance_;
-};
-
-template <typename Method, typename Class>
-RunnableImpl<Method, Class> MakeRunnable(Method method, Class object) {
- return RunnableImpl<Method, Class>(method, object);
-}
-
typedef mojo::Callback<void(double)> CalcCallback;
class MathCalculatorImpl : public math::Calculator {
@@ -222,6 +202,22 @@ class InterfacePtrTest : public testing::Test {
base::MessageLoop loop_;
};
+void SetFlagAndRunClosure(bool* flag, const base::Closure& closure) {
+ *flag = true;
+ closure.Run();
+}
+
+void IgnoreValueAndRunClosure(const base::Closure& closure, int32_t value) {
+ closure.Run();
+}
+
+void ExpectValueAndRunClosure(uint32_t expected_value,
+ const base::Closure& closure,
+ uint32_t value) {
+ EXPECT_EQ(expected_value, value);
+ closure.Run();
+}
+
TEST_F(InterfacePtrTest, IsBound) {
math::CalculatorPtr calc;
EXPECT_FALSE(calc.is_bound());
@@ -351,10 +347,8 @@ TEST_F(InterfacePtrTest, EncounteredErrorCallback) {
bool encountered_error = false;
base::RunLoop run_loop;
proxy.set_connection_error_handler(
- [&encountered_error, &run_loop]() {
- encountered_error = true;
- run_loop.Quit();
- });
+ base::Bind(&SetFlagAndRunClosure, &encountered_error,
+ run_loop.QuitClosure()));
MathCalculatorUI calculator_ui(std::move(proxy));
@@ -418,12 +412,12 @@ TEST_F(InterfacePtrTest, ReentrantWaitForIncomingMethodCall) {
ReentrantServiceImpl impl(GetProxy(&proxy));
base::RunLoop run_loop, run_loop2;
- auto called_cb = [&run_loop](int32_t result) { run_loop.Quit(); };
- auto called_cb2 = [&run_loop2](int32_t result) { run_loop2.Quit(); };
proxy->Frobinate(nullptr, sample::Service::BazOptions::REGULAR, nullptr,
- called_cb);
+ base::Bind(&IgnoreValueAndRunClosure,
+ run_loop.QuitClosure()));
proxy->Frobinate(nullptr, sample::Service::BazOptions::REGULAR, nullptr,
- called_cb2);
+ base::Bind(&IgnoreValueAndRunClosure,
+ run_loop2.QuitClosure()));
run_loop.Run();
run_loop2.Run();
@@ -439,12 +433,8 @@ TEST_F(InterfacePtrTest, QueryVersion) {
EXPECT_EQ(0u, ptr.version());
base::RunLoop run_loop;
- auto callback = [&run_loop](uint32_t version) {
- EXPECT_EQ(3u, version);
- run_loop.Quit();
- };
- ptr.QueryVersion(callback);
-
+ ptr.QueryVersion(base::Bind(&ExpectValueAndRunClosure, 3u,
+ run_loop.QuitClosure()));
run_loop.Run();
EXPECT_EQ(3u, ptr.version());
@@ -499,7 +489,7 @@ class StrongMathCalculatorImpl : public math::Calculator {
closure_(closure),
binding_(this, std::move(handle)) {
binding_.set_connection_error_handler(
- [this]() { *error_received_ = true; closure_.Run(); });
+ base::Bind(&SetFlagAndRunClosure, error_received_, closure_));
}
~StrongMathCalculatorImpl() override { *destroyed_ = true; }
@@ -573,7 +563,7 @@ class WeakMathCalculatorImpl : public math::Calculator {
closure_(closure),
binding_(this, std::move(handle)) {
binding_.set_connection_error_handler(
- [this]() { *error_received_ = true; closure_.Run(); });
+ base::Bind(&SetFlagAndRunClosure, error_received_, closure_));
}
~WeakMathCalculatorImpl() override { *destroyed_ = true; }
@@ -741,10 +731,7 @@ TEST_F(InterfacePtrTest, Fusion) {
// Ping!
bool called = false;
base::RunLoop loop;
- ptr->Ping([&called, &loop] {
- called = true;
- loop.Quit();
- });
+ ptr->Ping(base::Bind(&SetFlagAndRunClosure, &called, loop.QuitClosure()));
loop.Run();
EXPECT_TRUE(called);
}
« no previous file with comments | « mojo/public/cpp/bindings/tests/handle_passing_unittest.cc ('k') | mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698