Mojo C bindings library pt1: MojomBuffer

mojo/public/c/bindings/tests/buffer_unittest.cc

Index: mojo/public/c/bindings/tests/buffer_unittest.cc
diff --git a/mojo/public/c/bindings/tests/buffer_unittest.cc b/mojo/public/c/bindings/tests/buffer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fe9f7eecd105472cc2d696b3a324287265c4b54c
--- /dev/null
+++ b/mojo/public/c/bindings/tests/buffer_unittest.cc
@@ -0,0 +1,49 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mojo/public/c/bindings/buffer.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+TEST(MojomBufferTest, RoundTo8) {
+  char buffer[100];
+  struct MojomBuffer mbuf = {
+      buffer, sizeof(buffer),
+      0,  // num_bytes_used
+  };
+
+  // This should actually allocate 8 bytes:
+  EXPECT_EQ(buffer, MojomBuffer_Allocate(&mbuf, 6));
+  EXPECT_EQ(8ul, mbuf.num_bytes_used);
+  // The start of the next buffer is buffer + 8 bytes:
+  EXPECT_EQ(buffer + 8, MojomBuffer_Allocate(&mbuf, 6));
+  EXPECT_EQ(16ul, mbuf.num_bytes_used);
+  // 8-bye allocation results in 8-byte allocation.
+  EXPECT_EQ(buffer + 16, MojomBuffer_Allocate(&mbuf, 8));
+  EXPECT_EQ(24ul, mbuf.num_bytes_used);
+}
+
+TEST(MojomBufferTest, Failure) {
+  char buffer[100];
+  struct MojomBuffer mbuf = {
+      buffer, sizeof(buffer),
+      0,  // num_bytes_used
+  };
+
+  // Allocate too much space.
+  EXPECT_EQ(NULL, MojomBuffer_Allocate(&mbuf, sizeof(buffer) + 10));
+  // Allocating 0 bytes should fail as well.
+  EXPECT_EQ(NULL, MojomBuffer_Allocate(&mbuf, 0));
+
+  // Setup the buffer data so that it will overflow.
+  mbuf.num_bytes_used = UINT32_MAX - 7;  // This divides by 8.

[viettrungluu, 2016/06/15 15:59:49]

nit: You should probably explicitly include <stdint.h> for UINT32_MAX.

[vardhan, 2016/06/15 16:10:21]

Done.

+  mbuf.buf_size = UINT32_MAX;
+
+  // Rounds to 8, and allocates more than it has:
+  EXPECT_EQ(NULL, MojomBuffer_Allocate(&mbuf, 1));
+}
+
+}  // namespace