Make code compile with clang_use_chrome_plugin (part IV)

Make code compile with clang_use_chrome_plugin (part IV)

This change mainly contains files in fpdfsdk/ directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups plus removing an unused file and splitting
cxfa_eventparam out from fxfa.h

BUG=pdfium:469
Committed: https://pdfium.googlesource.com/pdfium/+/625ad667d0c0c17d5bc11d505f04861d90b45078

[Wei Li, 2016-06-15 16:50:31]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-06-15 16:50:32]

pls review, thanks

[dsinclair, 2016-06-15 17:08:03]

lgtm w/ nit.

https://codereview.chromium.org/2062313002/diff/40001/xfa/fxfa/app/xfa_eventp...
File xfa/fxfa/app/xfa_eventparam.cpp (right):

https://codereview.chromium.org/2062313002/diff/40001/xfa/fxfa/app/xfa_eventp...
xfa/fxfa/app/xfa_eventparam.cpp:6: 
Can we rename this and the .h to be cxfa_eventparam.{h|cpp}?

[Wei Li, 2016-06-15 17:50:30]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-15 17:50:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062313002/60001

[Wei Li, 2016-06-15 17:57:36]

thanks

https://codereview.chromium.org/2062313002/diff/40001/xfa/fxfa/app/xfa_eventp...
File xfa/fxfa/app/xfa_eventparam.cpp (right):

https://codereview.chromium.org/2062313002/diff/40001/xfa/fxfa/app/xfa_eventp...
xfa/fxfa/app/xfa_eventparam.cpp:6: 
On 2016/06/15 17:08:03, dsinclair wrote:
> Can we rename this and the .h to be cxfa_eventparam.{h|cpp}?

Done.

[Wei Li, 2016-06-15 18:06:00]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-06-15 18:06:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2062313002/#ps80001
(title: "remove unused file")

[commit-bot: I haz the power, 2016-06-15 18:06:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062313002/80001

[commit-bot: I haz the power, 2016-06-15 18:21:38]

Description was changed from

==========
Make code compile with clang_use_chrome_plugin (part IV)

This change mainly contains files in fpdfsdk/ directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups plus removing an unused file and splitting
cxfa_eventparam out from fxfa.h

BUG=pdfium:469
==========

to

==========
Make code compile with clang_use_chrome_plugin (part IV)

This change mainly contains files in fpdfsdk/ directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups plus removing an unused file and splitting
cxfa_eventparam out from fxfa.h

BUG=pdfium:469

Committed:
https://pdfium.googlesource.com/pdfium/+/625ad667d0c0c17d5bc11d505f04861d90b4...
==========

[commit-bot: I haz the power, 2016-06-15 18:21:39]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/625ad667d0c0c17d5bc11d505f04861d90b4...

[commit-bot: I haz the power, 2016-06-15 18:21:42]

CQ bit was unchecked