Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2062293002:
annotated_run: Use builder directory for temp. (Closed)
|
Created:
4 years, 6 months ago by dnj (Google) Modified:
4 years, 6 months ago Reviewers:
martiniss CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org Target Ref:
refs/heads/master Project:
build Visibility:
Public. |
Descriptionannotated_run: Use builder directory for temp.
bot_update assumes that it owns the build directory
(/b/build/slave/<slavename>/build), and occasionally nukes directories
underneath of it. We are currently using the build directory for
temporary files, and they are being destroyed.
Instead, use the builder directory for temporary files. This should
protect it from bot_update.
NOPRESUBMIT=true
NOTRY=true
BUG=chromium:620158
TEST=unittest
- Ran unittest, seems reasonable.
Committed: https://chromium.googlesource.com/chromium/tools/build/+/ed82e67abdd60ce13f7bdae56d648bd62776f0e3
Patch Set 1 #
Messages
Total messages: 26 (14 generated)
dnj@google.com changed reviewers: + martiniss@chromium.org
PTAL
lgtm
The CQ bit was checked by dnj@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062293002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by dnj@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062293002/1
Description was changed from ========== annotated_run: Use builder directory for temp. bot_update assumes that it owns the build directory (/b/build/slave/<slavename>/build), and occasionally nukes directories underneath of it. We are currently using the build directory for temporary files, and they are being destroyed. Instead, use the builder directory for temporary files. This should protect it from bot_update. BUG=chromium:620158 TEST=unittest - Ran unittest, seems reasonable. ========== to ========== annotated_run: Use builder directory for temp. bot_update assumes that it owns the build directory (/b/build/slave/<slavename>/build), and occasionally nukes directories underneath of it. We are currently using the build directory for temporary files, and they are being destroyed. Instead, use the builder directory for temporary files. This should protect it from bot_update. NOTRY=true BUG=chromium:620158 TEST=unittest - Ran unittest, seems reasonable. ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
The CQ bit was checked by dnj@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062293002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
Description was changed from ========== annotated_run: Use builder directory for temp. bot_update assumes that it owns the build directory (/b/build/slave/<slavename>/build), and occasionally nukes directories underneath of it. We are currently using the build directory for temporary files, and they are being destroyed. Instead, use the builder directory for temporary files. This should protect it from bot_update. NOTRY=true BUG=chromium:620158 TEST=unittest - Ran unittest, seems reasonable. ========== to ========== annotated_run: Use builder directory for temp. bot_update assumes that it owns the build directory (/b/build/slave/<slavename>/build), and occasionally nukes directories underneath of it. We are currently using the build directory for temporary files, and they are being destroyed. Instead, use the builder directory for temporary files. This should protect it from bot_update. NOPRESUBMIT=true NOTRY=true BUG=chromium:620158 TEST=unittest - Ran unittest, seems reasonable. ==========
The CQ bit was checked by dnj@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062293002/1
Message was sent while issue was closed.
Description was changed from ========== annotated_run: Use builder directory for temp. bot_update assumes that it owns the build directory (/b/build/slave/<slavename>/build), and occasionally nukes directories underneath of it. We are currently using the build directory for temporary files, and they are being destroyed. Instead, use the builder directory for temporary files. This should protect it from bot_update. NOPRESUBMIT=true NOTRY=true BUG=chromium:620158 TEST=unittest - Ran unittest, seems reasonable. ========== to ========== annotated_run: Use builder directory for temp. bot_update assumes that it owns the build directory (/b/build/slave/<slavename>/build), and occasionally nukes directories underneath of it. We are currently using the build directory for temporary files, and they are being destroyed. Instead, use the builder directory for temporary files. This should protect it from bot_update. NOPRESUBMIT=true NOTRY=true BUG=chromium:620158 TEST=unittest - Ran unittest, seems reasonable. Committed: https://chromium.googlesource.com/chromium/tools/build/+/ed82e67abdd60ce13f7b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/ed82e67abdd60ce13f7b...
Message was sent while issue was closed.
Description was changed from ========== annotated_run: Use builder directory for temp. bot_update assumes that it owns the build directory (/b/build/slave/<slavename>/build), and occasionally nukes directories underneath of it. We are currently using the build directory for temporary files, and they are being destroyed. Instead, use the builder directory for temporary files. This should protect it from bot_update. NOPRESUBMIT=true NOTRY=true BUG=chromium:620158 TEST=unittest - Ran unittest, seems reasonable. Committed: https://chromium.googlesource.com/chromium/tools/build/+/ed82e67abdd60ce13f7b... ========== to ========== annotated_run: Use builder directory for temp. bot_update assumes that it owns the build directory (/b/build/slave/<slavename>/build), and occasionally nukes directories underneath of it. We are currently using the build directory for temporary files, and they are being destroyed. Instead, use the builder directory for temporary files. This should protect it from bot_update. NOPRESUBMIT=true NOTRY=true BUG=chromium:620158 TEST=unittest - Ran unittest, seems reasonable. Committed: https://chromium.googlesource.com/chromium/tools/build/+/ed82e67abdd60ce13f7b... ==========
The CQ bit was checked by dnj@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062293002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
