Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2062263002: Remove debugging code for fixed bugs. Also clean up unused includes. (Closed)

Created:
4 years, 6 months ago by jam
Modified:
4 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, jam, Randy Smith (Not in Mondays)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove debugging code for fixed bugs. Also clean up unused includes. BUG=90971, 598073 Committed: https://crrev.com/95ba699eba9413f257437534e9e58dc42bfc82ae Cr-Commit-Position: refs/heads/master@{#399943}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : merge #

Patch Set 4 : merge again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -91 lines) Patch
M content/browser/loader/DEPS View 1 3 chunks +0 lines, -7 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 5 chunks +1 line, -16 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 9 chunks +0 lines, -55 lines 0 comments Download
M content/browser/resource_context_impl.cc View 1 2 3 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
jam
4 years, 6 months ago (2016-06-14 22:53:22 UTC) #3
scottmg
lgtm
4 years, 6 months ago (2016-06-14 22:56:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062263002/30007
4 years, 6 months ago (2016-06-15 04:27:31 UTC) #7
commit-bot: I haz the power
Failed to apply patch for content/browser/resource_context_impl.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-15 04:43:24 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 04:43:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062263002/50001
4 years, 6 months ago (2016-06-15 15:52:36 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/21546) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-15 15:55:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2062263002/90001
4 years, 6 months ago (2016-06-15 16:32:20 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:90001)
4 years, 6 months ago (2016-06-15 17:25:30 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 17:27:01 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/95ba699eba9413f257437534e9e58dc42bfc82ae
Cr-Commit-Position: refs/heads/master@{#399943}

Powered by Google App Engine
This is Rietveld 408576698