Source/core/fetch/ResourceLoader.cpp - Issue 206223005: Forbid setting responseType on all sync XHRs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/ResourceLoader.cpp

Issue 206223005: Forbid setting responseType on all sync XHRs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix tests that set responseType on sync XHRs. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/fetch/ResourceLoader.cpp

diff --git a/Source/core/fetch/ResourceLoader.cpp b/Source/core/fetch/ResourceLoader.cpp

index 9f786aade6f3c23943270388acf8d6dcc69a34aa..3942ec21436498d8bf9d72eccd2018d42591ee8d 100644

--- a/Source/core/fetch/ResourceLoader.cpp

+++ b/Source/core/fetch/ResourceLoader.cpp

@@ -448,6 +448,9 @@ void ResourceLoader::requestSynchronously()

OwnPtr<blink::WebURLLoader> loader = adoptPtr(blink::Platform::current()->createURLLoader());

ASSERT(loader);

+ // downloadToFile is not supported for synchronous requests.

+ ASSERT(!m_request.downloadToFile());

RefPtr<ResourceLoader> protect(this);

RefPtr<ResourceLoaderHost> protectHost(m_host);

ResourcePtr<Resource> protectResource(m_resource);