LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html - Issue 206223005: Forbid setting responseType on all sync XHRs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html

Issue 206223005: Forbid setting responseType on all sync XHRs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix tests that set responseType on sync XHRs. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/xhr-onclick-crash.html ('K') | « LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request-expected.txt ('k') | LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html

diff --git a/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html b/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html

index a96b16e99a9007478ccef8147a81c552e6eea986..1660e0392c5f3f87cef1f17b8b9db5fd71473214 100644

--- a/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html

+++ b/LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html

@@ -20,8 +20,7 @@

shouldBeEqualToString('window.location.protocol', 'file:');

xhr = new XMLHttpRequest();

xhr.open('GET', window.location.href, false);

- evalAndLog("xhr.responseType = 'document';");

- shouldBeEqualToString('xhr.responseType', 'document');

+ shouldThrow("xhr.responseType = 'document';");

// DATA

var dataUrl = 'data:text/html;charset=utf-8,%3C%21DOCTYPE%20' +

@@ -31,8 +30,7 @@

'%3C%2Fhtml%3E%0A%0D%0A';

xhr = new XMLHttpRequest();

xhr.open('GET', dataUrl, false);

- evalAndLog("xhr.responseType = 'document';");

- shouldBeEqualToString('xhr.responseType', 'document');

+ shouldThrow("xhr.responseType = 'document';");

</script>

</head>

<body>