Issue 206223003: JSArray::SetContent() handlified.

Issue 206223003: JSArray::SetContent() handlified. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko

Modified:
6 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

JSArray::SetContent() handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20145

Patch Set 2 : Addressing review notes #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -36 lines)			Patch
M	src/elements.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/factory.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/objects.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View	1	3 chunks	+25 lines, -14 lines	0 comments	Download
M	src/runtime.cc	View		6 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with a comment. https://codereview.chromium.org/206223003/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/206223003/diff/1/src/objects-inl.h#newcode6584 src/objects-inl.h:6584: // static We don't have ...

6 years, 9 months ago (2014-03-20 15:26:37 UTC) #2

Igor Sheludko

https://codereview.chromium.org/206223003/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/206223003/diff/1/src/objects-inl.h#newcode6584 src/objects-inl.h:6584: // static On 2014/03/20 15:26:38, Yang wrote: > We ...

6 years, 9 months ago (2014-03-21 08:25:11 UTC) #3

Yang

On 2014/03/21 08:25:11, Igor Sheludko wrote: > https://codereview.chromium.org/206223003/diff/1/src/objects-inl.h > File src/objects-inl.h (right): > > https://codereview.chromium.org/206223003/diff/1/src/objects-inl.h#newcode6584 ...

6 years, 9 months ago (2014-03-21 08:26:32 UTC) #4

Igor Sheludko

6 years, 9 months ago (2014-03-21 08:30:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20145 (presubmit successful).

Expand Messages | Collapse Messages