Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: content/child/indexed_db/indexed_db_dispatcher.cc

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Post dmurph review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/indexed_db/indexed_db_dispatcher.cc
diff --git a/content/child/indexed_db/indexed_db_dispatcher.cc b/content/child/indexed_db/indexed_db_dispatcher.cc
index aa40cca350f2e8548188b939f202ec53a261f290..1c7c3cae85e605a9622ec0c43b4a0ad25ad9e2e5 100644
--- a/content/child/indexed_db/indexed_db_dispatcher.cc
+++ b/content/child/indexed_db/indexed_db_dispatcher.cc
@@ -21,6 +21,7 @@
#include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabaseException.h"
#include "third_party/WebKit/public/platform/modules/indexeddb/WebIDBValue.h"
+using blink::IDBObserver;
using blink::WebBlobInfo;
using blink::WebData;
using blink::WebIDBCallbacks;
@@ -167,6 +168,28 @@ bool IndexedDBDispatcher::Send(IPC::Message* msg) {
return thread_safe_sender_->Send(msg);
}
+int32_t IndexedDBDispatcher::AddIDBObserver(int32_t ipc_database_id,
+ int64_t transaction_id,
+ blink::IDBObserver* observer) {
+ // TODO(palakj): generate id through IDMap here.
+ int32_t observer_id = 0;
+ Send(new IndexedDBHostMsg_DatabaseObserve(CurrentWorkerId(), ipc_database_id,
+ transaction_id, observer_id));
+ return observer_id;
+}
+
+std::vector<int32_t> IndexedDBDispatcher::RemoveIDBObserver(
+ int32_t ipc_database_id,
+ blink::IDBObserver* observer) {
+ std::vector<int32_t> remove_observers;
+ // TODO(palakj): iterate over map to find observer and collect id's in
+ // remove_observers
+
+ Send(new IndexedDBHostMsg_DatabaseUnobserve(
+ CurrentWorkerId(), ipc_database_id, remove_observers));
+ return remove_observers;
+}
+
void IndexedDBDispatcher::RequestIDBCursorAdvance(
unsigned long count,
WebIDBCallbacks* callbacks_ptr,

Powered by Google App Engine
This is Rietveld 408576698