Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1511)

Unified Diff: content/browser/indexed_db/indexed_db_dispatcher_host.h

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Post dmurph review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_dispatcher_host.h
diff --git a/content/browser/indexed_db/indexed_db_dispatcher_host.h b/content/browser/indexed_db/indexed_db_dispatcher_host.h
index ba7a65fe36a28ac86dabe84b51889b2aa7d1e551..0099cd8b11c426e9f83c1792b7af34eaa64604c7 100644
--- a/content/browser/indexed_db/indexed_db_dispatcher_host.h
+++ b/content/browser/indexed_db/indexed_db_dispatcher_host.h
@@ -174,6 +174,13 @@ class IndexedDBDispatcherHost : public BrowserMessageFilter {
void OnVersionChangeIgnored(int32_t ipc_database_id);
void OnDestroyed(int32_t ipc_database_id);
+ void OnObserve(int32_t ipc_thread_id,
+ int32_t ipc_database_id,
+ int64_t transaction_id,
+ int32_t observer_id);
+ void OnUnobserve(int32_t ipc_thread_id,
+ int32_t ipc_database_id,
+ std::vector<int32_t> remove_observers);
void OnGet(const IndexedDBHostMsg_DatabaseGet_Params& params);
void OnGetAll(const IndexedDBHostMsg_DatabaseGetAll_Params& params);
// OnPutWrapper starts on the IO thread so that it can grab BlobDataHandles
@@ -210,6 +217,10 @@ class IndexedDBDispatcherHost : public BrowserMessageFilter {
storage::QuotaStatusCode status,
int64_t usage,
int64_t quota);
+ int64_t GenerateObserverAndThreadId(int32_t observer_id,
+ int32_t ipc_thread_id);
+ std::vector<int64_t> RemoveObservers(std::vector<int32_t> remove_observers,
+ int32_t ipc_thread_id);
IndexedDBDispatcherHost* parent_;
IDMap<IndexedDBConnection, IDMapOwnPointer> map_;
@@ -217,6 +228,7 @@ class IndexedDBDispatcherHost : public BrowserMessageFilter {
TransactionIDToSizeMap transaction_size_map_;
TransactionIDToOriginMap transaction_origin_map_;
TransactionIDToDatabaseIDMap transaction_database_map_;
+ std::vector<std::pair<int32_t, int64_t>> observers_;
// Weak pointers are used when an asynchronous quota request is made, in
// case the dispatcher is torn down before the response returns.
@@ -299,7 +311,6 @@ class IndexedDBDispatcherHost : public BrowserMessageFilter {
// Only access on IndexedDB thread.
std::unique_ptr<DatabaseDispatcherHost> database_dispatcher_host_;
std::unique_ptr<CursorDispatcherHost> cursor_dispatcher_host_;
-
// Used to set file permissions for blob storage.
int ipc_process_id_;

Powered by Google App Engine
This is Rietveld 408576698