content/browser/indexed_db/indexed_db_database.h - Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_database.h

Issue 2062203004: IDBObserver: Lifetime Management: Adding Observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unobserve functionality Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/indexed_db/indexed_db_database.h

diff --git a/content/browser/indexed_db/indexed_db_database.h b/content/browser/indexed_db/indexed_db_database.h

index f659161cad5ff74c849697632c611a2e45eb9302..7b1c287d77fff25ead58686adaee99904e42c24e 100644

--- a/content/browser/indexed_db/indexed_db_database.h

+++ b/content/browser/indexed_db/indexed_db_database.h

@@ -51,7 +51,7 @@ class CONTENT_EXPORT IndexedDBDatabase

// Identifier is pair of (origin, database name).

using Identifier = std::pair<url::Origin, base::string16>;

- std::vector<std::unique_ptr<IndexedDBObserver>> active_observers_;

+ std::map<int64_t, IndexedDBObserver*> active_observers_;

static const int64_t kInvalidId = 0;

static const int64_t kMinimumIndexId = 30;

@@ -128,6 +128,7 @@ class CONTENT_EXPORT IndexedDBDatabase

void TransactionCommitFailed(const leveldb::Status& status);

void Observe(int64_t transaction_id, int64_t observer_id);

+ void Unobserve(std::vector<int64_t> observersToRemove);

void Get(int64_t transaction_id,

int64_t object_store_id,